Page MenuHomePhabricator

CI failure on Scribunto: Still uses removed ParserOptions::getUser()
Closed, ResolvedPublicBUG REPORT

Description

The gender option in mw.language tries to use ParserOptions::getUser(), see https://gerrit.wikimedia.org/g/mediawiki/extensions/Scribunto/+/e45e7b2f64250046325a7366c4352ed125f12699/includes/engines/LuaCommon/LanguageLibrary.php#283

That method was just removed, rMWa407ce41249f: Remove hard-deprecated methods returning User from Parser

This causes CI failures, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/726552, not sure about the user impact but I assume it'll trigger warnings about the missing method?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.

Change 726692 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/Scribunto@master] Replace deprecated ParserOptions::getUser with ::getUserIdentity

https://gerrit.wikimedia.org/r/726692

Oh wow, that's weird how this was missed.

Change 726692 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace deprecated ParserOptions::getUser with ::getUserIdentity

https://gerrit.wikimedia.org/r/726692

Change 726596 had a related patch set uploaded (by Jforrester; author: Ppchelko):

[mediawiki/extensions/Scribunto@wmf/1.38.0-wmf.3] Replace deprecated ParserOptions::getUser with ::getUserIdentity

https://gerrit.wikimedia.org/r/726596

Change 726597 had a related patch set uploaded (by Jforrester; author: Ppchelko):

[mediawiki/extensions/Scribunto@wmf/1.38.0-wmf.2] Replace deprecated ParserOptions::getUser with ::getUserIdentity

https://gerrit.wikimedia.org/r/726597

Jdforrester-WMF changed the subtype of this task from "Production Error" to "Bug Report".Oct 5 2021, 11:57 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Not a production error AFAICT?

Jdforrester-WMF renamed this task from Scribunto uses removed ParserOptions::getUser() to CI failure on Scribunto: Still uses removed ParserOptions::getUser().Oct 5 2021, 11:58 PM

Not a production error AFAICT?

Sorry, I created this from the train blocks link and that was the default

Should this still be considered a train blocker?

Yes, this could potentially happen in production too and we already have the fix, so let's backport the fix.

Mentioned in SAL (#wikimedia-operations) [2021-10-06T15:45:47Z] <brennen> 1.38.0-wmf.3 train (T281167): proceeding to deploy backports for T292589

Change 726597 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@wmf/1.38.0-wmf.2] Replace deprecated ParserOptions::getUser with ::getUserIdentity

https://gerrit.wikimedia.org/r/726597

Change 726596 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@wmf/1.38.0-wmf.3] Replace deprecated ParserOptions::getUser with ::getUserIdentity

https://gerrit.wikimedia.org/r/726596

Mentioned in SAL (#wikimedia-operations) [2021-10-06T16:28:49Z] <brennen@deploy1002> Synchronized php-1.38.0-wmf.2/extensions/Scribunto/includes/engines/LuaCommon/LanguageLibrary.php: Backport: [[gerrit:726597|Replace deprecated ParserOptions::getUser with ::getUserIdentity (T292589)]] (duration: 01m 10s)

Mentioned in SAL (#wikimedia-operations) [2021-10-06T16:35:28Z] <brennen@deploy1002> Synchronized php-1.38.0-wmf.3/extensions/Scribunto/includes/engines/LuaCommon/LanguageLibrary.php: Backport: [[gerrit:726596|Replace deprecated ParserOptions::getUser with ::getUserIdentity (T292589)]] (duration: 01m 04s)

brennen claimed this task.