Page MenuHomePhabricator
Create Task
Maniphest T292590

TypeError: Argument 1 passed to MediaWiki\CommentFormatter\CommentItem::__construct() must be of the type string, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to MediaWiki\CommentFormatter\CommentItem::__construct() must be of the type string, null given, called in /srv/mediawiki/php-1.38.0-wmf.3/includes/CommentFormatter/RowCommentIterator.php on line 11
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.3/includes/CommentFormatter/CommentItem.php(41)
#0 /srv/mediawiki/php-1.38.0-wmf.3/includes/CommentFormatter/RowCommentIterator.php(115): MediaWiki\CommentFormatter\CommentItem->__construct(NULL)
#1 /srv/mediawiki/php-1.38.0-wmf.3/includes/CommentFormatter/CommentFormatter.php(316): MediaWiki\CommentFormatter\RowCommentIterator->current()
#2 /srv/mediawiki/php-1.38.0-wmf.3/includes/CommentFormatter/CommentBatch.php(190): MediaWiki\CommentFormatter\CommentFormatter->formatItemsInternal(MediaWiki\CommentFormatter\RowCommentIterator, NULL, NULL, NULL, NULL, boolean, boolean)
#3 /srv/mediawiki/php-1.38.0-wmf.3/includes/CommentFormatter/RowCommentFormatter.php(86): MediaWiki\CommentFormatter\CommentBatch->execute()
#4 /srv/mediawiki/php-1.38.0-wmf.3/includes/specials/pagers/ProtectedPagesPager.php(128): MediaWiki\CommentFormatter\RowCommentFormatter->formatRows(Wikimedia\Rdbms\MysqliResultWrapper, string)
#5 /srv/mediawiki/php-1.38.0-wmf.3/includes/pager/IndexPager.php(290): ProtectedPagesPager->preprocessResults(Wikimedia\Rdbms\MysqliResultWrapper)
#6 /srv/mediawiki/php-1.38.0-wmf.3/includes/pager/IndexPager.php(744): IndexPager->doQuery()
#7 /srv/mediawiki/php-1.38.0-wmf.3/includes/specials/SpecialProtectedpages.php(120): IndexPager->getNumRows()
#8 /srv/mediawiki/php-1.38.0-wmf.3/includes/specialpage/SpecialPage.php(647): SpecialProtectedpages->execute(NULL)
#9 /srv/mediawiki/php-1.38.0-wmf.3/includes/specialpage/SpecialPageFactory.php(1375): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(925): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(559): MediaWiki->main()
#13 /srv/mediawiki/php-1.38.0-wmf.3/index.php(53): MediaWiki->run()
#14 /srv/mediawiki/php-1.38.0-wmf.3/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
Impact

User-facing error at URL.

Notes

Have seen 2 of these since rolling 1.37.0-wmf.3 (T281167) to group 0.

Presumably also CommentFormatter fallout, as in T292570.

Details

MediaWiki Version
1.38.0-wmf.3
Request URL
https://mn.wikibooks.org/wiki/%D0%A2%D1%83%D1%81%D0%B3%D0%B0%D0%B9:ProtectedPages
SubjectRepoBranchLines +/-
RowCommentIterator: Cast data coming out of the DBmediawiki/corewmf/1.38.0-wmf.3+2 -2
RowCommentIterator: Cast data coming out of the DBmediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

brennen created this task.Oct 5 2021, 9:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2021, 9:54 PM
brennen added a parent task: T281167: 1.38.0-wmf.3 deployment blockers.Oct 5 2021, 10:00 PM
• Pchelolo added a comment.Oct 5 2021, 10:01 PM

This is CommentFormatter as well. cc @TimStarling

gerritbot added a comment.Oct 5 2021, 10:07 PM

Change 726698 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] RowCommentIterator: Cast data coming out of the DB

https://gerrit.wikimedia.org/r/726698

gerritbot added a project: Patch-For-Review.Oct 5 2021, 10:07 PM
gerritbot added a comment.Oct 6 2021, 12:37 AM

Change 726698 merged by jenkins-bot:

[mediawiki/core@master] RowCommentIterator: Cast data coming out of the DB

https://gerrit.wikimedia.org/r/726698

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 6 2021, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 6 2021, 1:10 AM
gerritbot added a comment.Oct 6 2021, 2:11 AM

Change 726602 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@wmf/1.38.0-wmf.3] RowCommentIterator: Cast data coming out of the DB

https://gerrit.wikimedia.org/r/726602

gerritbot added a project: Patch-For-Review.Oct 6 2021, 2:11 AM
gerritbot added a comment.Oct 6 2021, 3:07 AM

Change 726602 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.3] RowCommentIterator: Cast data coming out of the DB

https://gerrit.wikimedia.org/r/726602

Maintenance_bot removed a project: Patch-For-Review.Oct 6 2021, 3:10 AM
Stashbot added a comment.Oct 6 2021, 3:11 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-06T03:11:53Z] <tstarling@deploy1002> Synchronized php-1.38.0-wmf.3/includes/CommentFormatter/RowCommentIterator.php: fix UBN T292590 (duration: 01m 04s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.3; 2021-10-05); removed MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 6 2021, 4:00 AM
brennen closed this task as Resolved.Oct 6 2021, 4:42 PM
brennen claimed this task.
Krinkle moved this task from Untriaged to Oct 2021 on the Wikimedia-production-error board.Oct 25 2021, 6:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL