Page MenuHomePhabricator

Update all skinStyles to apply to new Vector skin keys
Closed, ResolvedPublic3 Estimated Story Points

Description

Vector will be split into 2 skins with key vector and vector-2022 (see Ibaddf94a5bfb5e21bbbaf1e0aa1b343a3f566d2d).

When this has occurred we will need to update all skinStyles keys across Wikimedia deployed code to reference the new keys:

https://codesearch.wmcloud.org/deployed/?q=skinStyles%22&i=nope&files=.*json&excludeFiles=docs%2F*&repos=

Acceptance criteria

Update the following so that any skin style entries duplicate vector with an identical vector-2022
Make sure to update skinStyles in ResourceModules

Do not change any existing skin styles (For example in Echo where vector has vector-2022 code) as it is not safe to do this until the migration has been completed.

  • ContentTranslation
  • Echo
  • GrowthExperiments
  • GuidedTour
  • MobileFrontend
  • UniversalLanguageSelector
  • VisualEditor
  • WikimediaBadges

Non-blockers (not desktop improvements wikis)

For these please provide a patch, but this can be broken out into a separate ticket if needed.

  • ProofReadPage
  • Translate
  • Wikibase

Event Timeline

Jdlrobson triaged this task as Medium priority.Dec 9 2021, 7:36 PM
Jdlrobson raised the priority of this task from Medium to High.Fri, Jan 7, 6:31 PM

Change 752734 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/ContentTranslation@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752734

Change 752735 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/Echo@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752735

Change 752736 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/GrowthExperiments@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752736

Change 752740 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/GuidedTour@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752740

Change 752744 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/MobileFrontend@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752744

Change 752747 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/UniversalLanguageSelector@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752747

Change 752753 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/VisualEditor@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752753

Change 752744 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752744

Change 752747 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752747

Change 752735 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752735

Change 752757 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/WikimediaBadges@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752757

Change 752757 merged by jenkins-bot:

[mediawiki/extensions/WikimediaBadges@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752757

Change 752740 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752740

Change 752753 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752753

Change 752734 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752734

CI seems to be failing on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/752736 . I am hoping the Growth team can take a look at their earliest convenience.

Change 752761 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/ProofreadPage@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752761

Change 752762 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/Translate@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752762

Change 752765 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/Wikibase@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752765

Change 752761 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752761

Change 752736 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752736

Change 752765 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update skinStyles with new vector skin key.

https://gerrit.wikimedia.org/r/752765

Change 752762 abandoned by Jdlrobson:

[mediawiki/extensions/Translate@master] Update skinStyles with new vector skin key.

Reason:

Not needed apparently

https://gerrit.wikimedia.org/r/752762

nray reassigned this task from nray to Jdlrobson.
nray added a subscriber: nray.