DiscussionTools: PHP Notice: Trying to get property 'nodeName' of non-object
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	Oct 6 2021, 6:29 PM

Description

Error

mwversion: 1.38.0-wmf.2
reqId: 7dabcf19-24e9-4b56-a6e7-66dd2df58e2b
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Trying to get property 'nodeName' of non-object

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.2/extensions/DiscussionTools/includes/CommentModifier.php(494)
#0 /srv/mediawiki/php-1.38.0-wmf.2/extensions/DiscussionTools/includes/CommentModifier.php(494): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.38.0-wmf.2/extensions/DiscussionTools/includes/CommentModifier.php(587): MediaWiki\Extension\DiscussionTools\CommentModifier::appendSignature(Wikimedia\Parsoid\DOM\Compat\Element)
#2 /srv/mediawiki/php-1.38.0-wmf.2/extensions/DiscussionTools/includes/ApiDiscussionToolsEdit.php(178): MediaWiki\Extension\DiscussionTools\CommentModifier::addHtmlReply(MediaWiki\Extension\DiscussionTools\CommentItem, string)
#3 /srv/mediawiki/php-1.38.0-wmf.2/includes/api/ApiMain.php(1877): MediaWiki\Extension\DiscussionTools\ApiDiscussionToolsEdit->execute()
#4 /srv/mediawiki/php-1.38.0-wmf.2/includes/api/ApiMain.php(856): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.38.0-wmf.2/includes/api/ApiMain.php(827): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.38.0-wmf.2/api.php(90): ApiMain->execute()
#7 /srv/mediawiki/php-1.38.0-wmf.2/api.php(45): wfApiMain()
#8 /srv/mediawiki/w/api.php(3): require(string)
#9 {main}

Impact

Noted one of these in 1.38.0-wmf.2.

Notes

Details

Request URL: https://nl.wikipedia.org/w/api.php

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	modifier: Handle empty nodes in appendSignature()	mediawiki/extensions/DiscussionTools	master	+2 -2

Customize query in gerrit

Event Timeline

brennen created this task.Oct 6 2021, 6:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 6 2021, 6:29 PM

brennen moved this task from Untriaged to Oct 2021 on the Wikimedia-production-error board.Oct 6 2021, 6:51 PM

Looks like this might happen when someone posts an empty reply.

By the way, the "Find normalized_message in Logstash" link doesn't work, and has never worked for me, in any of the bug reports following this template. Is there a trick to it?

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.Oct 7 2021, 4:46 PM

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.

matmarex moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.Oct 7 2021, 6:00 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Oct 7 2021, 10:29 PM

It's a very rare error, apparently 6 occurrences ever: https://logstash.wikimedia.org/goto/4a16b5dc5162baed88ec099f80ce87ea

Change 730043 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] modifier: Handle empty nodes in appendSignature()

https://gerrit.wikimedia.org/r/730043

gerritbot added a project: Patch-For-Review.Oct 11 2021, 8:18 PM

matmarex claimed this task.Oct 11 2021, 8:18 PM

matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

Change 730043 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] modifier: Handle empty nodes in appendSignature()

https://gerrit.wikimedia.org/r/730043

DLynch moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 13 2021, 5:28 PM

DLynch added a project: Skipped QA.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 13 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2021, 6:10 PM

ppelberg closed this task as Resolved.Oct 16 2021, 12:41 AM

	F34685290: image.png
	Oct 11 2021, 8:16 PM

DiscussionTools: PHP Notice: Trying to get property 'nodeName' of non-objectClosed, ResolvedPublicPRODUCTION ERRORActions