🎬️ desktop-de-07 | Extended banner form | ⏰ Oct 26th
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	kai.nissen
	Oct 7 2021, 11:16 AM

Description

After several tests using a second banner form page asking for the address type, we want to test the effect of making this visible initially. The control banner is based on the control banner of desktop-de-05.

Acceptance Criteria

Both banners use the control donation form of desktop-de-06.
The second banner form page is added to the control banner (as seen in the design file).
The variant banner is split into 3 columns (as seen in the design file).
The left column containing the text slider has a variable width.
The banner's form is never displayed below the text slider.
The banners are of the same height.
Banner screenshots are uploaded to Shutterbug.

Notes

The latest version of the desktop banners should be used.

Related Objects
Search...

Status	Assigned	Task
Resolved	kai.nissen	T292712 🎬️ desktop-de-07 \| Campaign setup \| ⏰ Oct 26th
Resolved	None	T292713 🎬️ desktop-de-07 \| Extended banner form \| ⏰ Oct 26th
Resolved	None	T294324 🎬️ desktop-de-07 \| Prevent banner display in small viewports \| ⏰ Oct 26th

Event Timeline

kai.nissen created this task.Oct 7 2021, 11:16 AM

kai.nissen mentioned this in T292715: 🎬️ desktop-de-08 | Campaign setup | ⏰ Nov 3rd.

Maintenance_bot added a project: WMDE-FUN-Team.Oct 7 2021, 11:46 AM

kai.nissen updated the task description. (Show Details)Oct 7 2021, 11:58 AM

kai.nissen updated the task description. (Show Details)Oct 7 2021, 12:41 PM

kai.nissen set the point value for this task to 8.

kai.nissen moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.Oct 8 2021, 9:27 AM

kai.nissen updated the task description. (Show Details)Oct 8 2021, 11:13 AM

AbbanWMDE added a project: WMDE-FUN-Sprint-2021-10-11.Oct 11 2021, 9:31 AM

CorinnaHillebrand_WMDE moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.Oct 11 2021, 9:32 AM

AbbanWMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2021-10-11 board.Oct 18 2021, 5:24 AM

kai.nissen updated the task description. (Show Details)Oct 18 2021, 6:19 AM

AbbanWMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2021-10-11 board.Oct 22 2021, 11:09 AM

PR: https://github.com/wmde/fundraising-banners/pull/732
Tested in IE11/Edge Legacy

Thanks, @AbbanWMDE! Some things, though:

The impCount parameter is passed as NaN.
The parameter ast=1 should be passed instead of provadd=1.
The slide content is left aligned if only one line is used.

I'm also thinking that we should prevent banner display below a viewport width of ~900px. There aren't many impressions, anyway.

kai.nissen moved this task from Review to Todo on the WMDE-FUN-Sprint-2021-10-11 board.Oct 25 2021, 8:40 AM

kai.nissen changed the point value for this task from 8 to 1.Oct 25 2021, 10:31 AM

kai.nissen added a project: WMDE-FUN-Funban-2021.

kai.nissen moved this task from Backlog to Ready for Work on the WMDE-FUN-Funban-2021 board.Oct 25 2021, 10:35 AM

@AbbanWMDE
Logging with schema WMDEBannerEvents isn't working well. The close event sends finalSlide as 0 and the events triggered on opening the use of funds and clicking the button at the bottom of the overlay send finalSlide as null.

@kai.nissen Those fixes should be in now, including the finalSlide one

kai.nissen renamed this task from 🎬️ desktop-de-07 | Extended banner form | ⏰ Oct 25th to 🎬️ desktop-de-07 | Extended banner form | ⏰ Oct 26th.Oct 26 2021, 6:02 AM

AbbanWMDE assigned this task to kai.nissen.Oct 26 2021, 7:03 AM

AbbanWMDE moved this task from Ready for Work to Acceptance Testing (Banners) on the WMDE-FUN-Funban-2021 board.

kai.nissen removed kai.nissen as the assignee of this task.Oct 26 2021, 2:42 PM

kai.nissen moved this task from Acceptance Testing (Banners) to Code Review (max. 3 tasks) on the WMDE-FUN-Funban-2021 board.

CorinnaHillebrand_WMDE moved this task from Code Review (max. 3 tasks) to Done on the WMDE-FUN-Funban-2021 board.Nov 3 2021, 5:06 PM

kai.nissen closed this task as Resolved.Jan 3 2022, 9:59 AM

kai.nissen closed subtask T294324: 🎬️ desktop-de-07 | Prevent banner display in small viewports | ⏰ Oct 26th as Resolved.