Page MenuHomePhabricator

SyntaxHighlight always highlights syntax errors in red
Closed, ResolvedPublic

Description

image.png (121×726 px, 18 KB)

(from https://www.mediawiki.org/wiki/Specs/HTML/2.2.0#Images)

While this may be helpful when authoring, we should consider disabling this by default, or at least making it configurable.

Event Timeline

I'm wondering if this is due to the recent ShellBox changes.. I've suddenly seen it a lot more I feel.

This particular case seems like a case where it would make more sense to have two blocks (which would a) ensure the requirements are clear for a user of that specification and which would b) coincidentally avoid an error being highlighted in red ;).

I suspect the order of CSS file inclusion changed in T289227: Convert SyntaxHighlight to use Shellbox and due to equal specificity our override is no longer working

Screenshot 2021-10-07 at 17.34.11.png (364×377 px, 39 KB)

Change 729846 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Include generated styles before Mediawiki overrides

https://gerrit.wikimedia.org/r/729846

Change 729846 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Include generated styles before Mediawiki overrides

https://gerrit.wikimedia.org/r/729846

Esanders claimed this task.
Esanders moved this task from Backlog to Accepted on the SyntaxHighlight board.

Sorry about this, I'll get the fix backported.

Change 730233 had a related patch set uploaded (by Legoktm; author: TheDJ):

[mediawiki/extensions/SyntaxHighlight_GeSHi@wmf/1.38.0-wmf.3] Include generated styles before Mediawiki overrides

https://gerrit.wikimedia.org/r/730233

Change 730234 had a related patch set uploaded (by Legoktm; author: TheDJ):

[mediawiki/extensions/SyntaxHighlight_GeSHi@REL1_37] Include generated styles before Mediawiki overrides

https://gerrit.wikimedia.org/r/730234

Change 730234 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@REL1_37] Include generated styles before Mediawiki overrides

https://gerrit.wikimedia.org/r/730234

Change 730233 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@wmf/1.38.0-wmf.3] Include generated styles before Mediawiki overrides

https://gerrit.wikimedia.org/r/730233

Mentioned in SAL (#wikimedia-operations) [2021-10-12T17:32:02Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.3/extensions/SyntaxHighlight_GeSHi/includes/ResourceLoaderPygmentsModule.php: Backport: [[gerrit:730233|Include generated styles before Mediawiki overrides (T292736)]] (duration: 00m 57s)

Did we miss some cache invalidation step?

yes likely this change didn't cause a cache purge

All pages seem fixed now.