Page MenuHomePhabricator

Missing margins on some information boxes in the mobile skin
Closed, ResolvedPublic

Description

Note the difference between the two gray (i) boxes.

Screenshot from 2021-10-07 15-43-35.png (743×926 px, 97 KB)

Event Timeline

Change 721300 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Include TemplatePage styling on mobile

https://gerrit.wikimedia.org/r/721300

Change 753726 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Add mobile specific styling for TemplatePage

https://gerrit.wikimedia.org/r/753726

Change 721300 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Include TemplatePage styling on mobile

https://gerrit.wikimedia.org/r/721300

@ECohen_WMDE We noticed that the mobile and desktop skins differ in the margin around the content pane. This looks accidental (I don't see that it has been explicitly specified anywhere), but I wanted to check with you because we've merged a patch which makes the margin the same (larger margins for both skins), and we're waiting for your opinion before merging the other patch, which restores the smaller margin on mobile.

Desktop:

image.png (467×1 px, 43 KB)

Mobile:

image.png (432×1 px, 54 KB)

@awight This was intentional - there were no tickets because I think at one point we discussed keeping the original, smaller mobile margins but nothing needed to be done to do that. So go ahead and keep the smaller ones now, sorry about the lack of clear documentation. Thanks for asking!

(Looks a bit weird when minvera is used on desktop, but on actual mobile devices the smaller margins are important)

Change 753726 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add mobile specific styling for TemplatePage

https://gerrit.wikimedia.org/r/753726

Closing this ticket as the issue is resolved. I'm planning to review margins/padding on mobile, but if I find anything that needs changes, I'll make a follow-up ticket