Page MenuHomePhabricator

Suggested edits: icons are too small in task preview card on mobile
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enable Growth features
  • Go to Special:Homepage on mobile

What happens?:

Screen Shot 2021-10-07 at 10.03.00 AM.png (504×730 px, 112 KB)

Strangely the actual width is ~10px even though the width is explicitly set to 16px.

Screen Shot 2021-10-07 at 10.04.33 AM.png (276×754 px, 90 KB)

The same component is used in the post-edit dialog and the icon size is correct there.

Screen Shot 2021-10-07 at 10.08.04 AM.png (532×758 px, 103 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
mewoph edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
mewoph moved this task from Incoming to In Progress on the Growth-Team (Current Sprint) board.
mewoph updated the task description. (Show Details)

Change 727428 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: explicitly set min-width for icons in SmallTaskCard

https://gerrit.wikimedia.org/r/727428

Change 727428 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: explicitly set min-width for icons in SmallTaskCard

https://gerrit.wikimedia.org/r/727428

Etonkovidova added a subscriber: Etonkovidova.

Checked in betlabs

wmf.2betalabsafter the fix
Screen Shot 2021-10-07 at 1.39.04 PM.png (806×872 px, 171 KB)
Screen Shot 2021-10-07 at 1.38.06 PM.png (756×1 px, 182 KB)

@mewoph - in wmf.3 on iOS 13 real device (375 x 667) the robot icon is missing. The icon will be displayed in a landscape mode .

IMG_0348.PNG (1×640 px, 189 KB)

Android (Samsung Galaxy 8) does not have the issue. To reproduce the issue in a browser simulator - the width should be <355px.

Thanks @Etonkovidova — I was unable to reproduce on an iPhone mini as well as in a browser simulator. Is this also an issue w/the post-edit dialog?

Screen Shot 2021-10-07 at 4.15.55 PM.png (1×630 px, 155 KB)

I think it should be fixed by the min-width patch linked on this task, at least it is when I look at https://en.m.wikipedia.beta.wmflabs.org

Here's how it looks in wmf.3

Thanks @Etonkovidova — I was unable to reproduce on an iPhone mini as well as in a browser simulator. Is this also an issue w/the post-edit dialog?

Screen Shot 2021-10-07 at 4.15.55 PM.png (1×630 px, 155 KB)

I think it should be fixed by the min-width patch linked on this task, at least it is when I look at https://en.m.wikipedia.beta.wmflabs.org

Here's how it looks in wmf.3

Re-checked - the fix works as expected. I was thinking about prioritizing the fix for backporting - but it seems that the impact is relatively low and the deployment train is coming soon.