Page MenuHomePhabricator
Create Task
Maniphest T292791

Oldest revisions not listed in the correct order
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Visit any Wikipedia article
  • Click on the "View history" link (Vector) or the "history" link (Monobook)
  • Click on the "oldest" link where it says "(newest | oldest) View (newer 50 | older 50) (20 | 50 | 100 | 250 | 500)"

What happens?: The revisions are listed in chronological order, from oldest to newest.

What should have happened instead?: The revisions are listed in reverse chronological order, from newest to oldest.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

SubjectRepoBranchLines +/-
Fix history page iteration in backwards modemediawiki/corewmf/1.38.0-wmf.4+13 -6
Fix history page iteration in backwards modemediawiki/corewmf/1.38.0-wmf.3+13 -6
Fix history page iteration in backwards modemediawiki/coremaster+13 -6
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedancyT281168 1.38.0-wmf.4 deployment blockers
 ResolvedBUG REPORTdancyT292791 Oldest revisions not listed in the correct order

Event Timeline

GTrang created this task.Oct 7 2021, 8:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2021, 8:56 PM
Zabe subscribed.Oct 7 2021, 8:57 PM
GTrang updated the task description. (Show Details)Oct 7 2021, 9:00 PM
Zabe added a project: Regression.Oct 7 2021, 9:03 PM
GTrang updated the task description. (Show Details)Oct 7 2021, 9:04 PM
Nintendofan885 subscribed.Oct 7 2021, 10:12 PM
GTrang merged a task: T292813: page history out of order for earliest revisions in certain pages.Oct 8 2021, 4:12 AM
GTrang added a subscriber: Graham87.
Pcoombe merged a task: T292869: Article histories missing or corrupted.Oct 8 2021, 6:49 PM
Pcoombe added a subscriber: Pigsonthewing.
Pcoombe subscribed.Oct 8 2021, 6:56 PM

Note that reversing the order of revisions on the history page has also broken the bytes changed number, and the "prev" diff links

DuncanHill subscribed.Oct 8 2021, 7:12 PM

Also if you click on "history" and then on "older 50" you only get a handful of revisions, apparently chosen at random.

Legoktm subscribed.Oct 8 2021, 7:14 PM

Also reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Upside-down_history

Legoktm mentioned this in T281167: 1.38.0-wmf.3 deployment blockers.Oct 8 2021, 7:15 PM
Pigsonthewing added a comment.Oct 8 2021, 7:18 PM

Diffs are also broken; see examples in T292869

brennen added projects: Platform Engineering, User-brennen.Oct 8 2021, 7:45 PM
brennen added subscribers: • Pchelolo, tstarling, brennen.

@Pchelolo @tstarling by any chance something to do with CommentFormatter?

AntiCompositeNumber subscribed.Oct 8 2021, 7:52 PM

git bisect does indeed blame rMWf7f84dddb33e: Introduce CommentFormatter.

brennen added a comment.Oct 8 2021, 8:06 PM

After discussion within RelEng, we're evaluating this as not warranting a rollback of the 1.38.0-wmf.3 train late on a Friday, although a backported fix would be welcome. If there's a scenario where this is leading to data loss or other concerns warranting a rollback, please let us know.

Jdforrester-WMF subscribed.Oct 8 2021, 8:40 PM
brennen added a subscriber: daniel.Oct 8 2021, 8:54 PM

Ok, so @daniel has a revert here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/728537

Deploying that.

brennen added a comment.Oct 8 2021, 9:12 PM

Deploying that.

Scratch that; revert patch contains unresolved merge conflicts I'm not qualified to evaluate.

brennen triaged this task as Unbreak Now! priority.Oct 8 2021, 9:43 PM
brennen added a parent task: T281168: 1.38.0-wmf.4 deployment blockers.

For the time being, marking this as a blocker for next week's 1.38.0-wmf.4.

• Krassotkin subscribed.Oct 9 2021, 7:38 AM
MBH subscribed.Oct 9 2021, 8:09 AM
MBH added a comment.Oct 10 2021, 8:01 AM
  1. Go to link https://ru.wikipedia.org/w/index.php?title=Project:К_посредничеству/Украина/Запросы&offset=20180908134724|94961911&limit=500&action=history
  2. Press "500 newer"

You'll get this page https://ru.wikipedia.org/w/index.php?title=Project:К_посредничеству/Украина/Запросы&dir=prev&offset=20180908132720|94961435&limit=500&action=history , with inverted order of edits and incorrect size diffs (+992 069) (−984 242‎) on all 500 edits.

Looks like this is the same problem.

Strainu subscribed.Oct 10 2021, 12:25 PM
Risker subscribed.Oct 11 2021, 12:30 AM
gerritbot added a comment.Oct 11 2021, 12:52 AM

Change 729892 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/729892

gerritbot added a project: Patch-For-Review.Oct 11 2021, 12:52 AM
tstarling added a comment.Oct 11 2021, 12:55 AM

Fully isolated, fix proposed. It was a massive brain fart to use $this->counter as a result offset.

Asartea subscribed.Oct 11 2021, 8:05 AM
matmarex subscribed.Oct 11 2021, 10:27 PM
Daimona subscribed.Oct 12 2021, 10:10 AM
gerritbot added a comment.Oct 12 2021, 4:41 PM

Change 730235 had a related patch set uploaded (by Brennen Bearnes; author: Tim Starling):

[mediawiki/core@wmf/1.38.0-wmf.3] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/730235

gerritbot added a comment.Oct 12 2021, 4:41 PM

Change 730236 had a related patch set uploaded (by Brennen Bearnes; author: Tim Starling):

[mediawiki/core@wmf/1.38.0-wmf.4] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/730236

gerritbot added a comment.Oct 12 2021, 4:50 PM

Change 729892 merged by jenkins-bot:

[mediawiki/core@master] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/729892

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 12 2021, 5:00 PM
gerritbot added a comment.Oct 12 2021, 5:13 PM

Change 730235 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.3] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/730235

Stashbot added a comment.Oct 12 2021, 5:16 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-12T17:16:13Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.3/includes/actions/pagers/HistoryPager.php: Backport: [[gerrit:730235|Fix history page iteration in backwards mode (T292791)]] (duration: 00m 57s)

gerritbot added a comment.Oct 12 2021, 5:17 PM

Change 730236 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.4] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/730236

Stashbot added a comment.Oct 12 2021, 5:23 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-12T17:23:31Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/includes/actions/pagers/HistoryPager.php: Backport: [[gerrit:730236|Fix history page iteration in backwards mode (T292791)]] (duration: 00m 57s)

dancy closed this task as Resolved.Oct 12 2021, 5:24 PM
dancy claimed this task.
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.3; 2021-10-05); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 12 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 12 2021, 6:10 PM
Krinkle mentioned this in T293293: ReverseChronologicalPager::checkdate warns "PHP Notice: A non well formed numeric value encountered".Oct 13 2021, 6:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL