Page MenuHomePhabricator

Oldest revisions not listed in the correct order
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Visit any Wikipedia article
  • Click on the "View history" link (Vector) or the "history" link (Monobook)
  • Click on the "oldest" link where it says "(newest | oldest) View (newer 50 | older 50) (20 | 50 | 100 | 250 | 500)"

What happens?: The revisions are listed in chronological order, from oldest to newest.

What should have happened instead?: The revisions are listed in reverse chronological order, from newest to oldest.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

Note that reversing the order of revisions on the history page has also broken the bytes changed number, and the "prev" diff links

Also if you click on "history" and then on "older 50" you only get a handful of revisions, apparently chosen at random.

Diffs are also broken; see examples in T292869

After discussion within RelEng, we're evaluating this as not warranting a rollback of the 1.38.0-wmf.3 train late on a Friday, although a backported fix would be welcome. If there's a scenario where this is leading to data loss or other concerns warranting a rollback, please let us know.

Deploying that.

Scratch that; revert patch contains unresolved merge conflicts I'm not qualified to evaluate.

brennen triaged this task as Unbreak Now! priority.Fri, Oct 8, 9:43 PM

For the time being, marking this as a blocker for next week's 1.38.0-wmf.4.

Change 729892 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/729892

Fully isolated, fix proposed. It was a massive brain fart to use $this->counter as a result offset.

Change 730235 had a related patch set uploaded (by Brennen Bearnes; author: Tim Starling):

[mediawiki/core@wmf/1.38.0-wmf.3] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/730235

Change 730236 had a related patch set uploaded (by Brennen Bearnes; author: Tim Starling):

[mediawiki/core@wmf/1.38.0-wmf.4] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/730236

Change 729892 merged by jenkins-bot:

[mediawiki/core@master] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/729892

Change 730235 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.3] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/730235

Mentioned in SAL (#wikimedia-operations) [2021-10-12T17:16:13Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.3/includes/actions/pagers/HistoryPager.php: Backport: [[gerrit:730235|Fix history page iteration in backwards mode (T292791)]] (duration: 00m 57s)

Change 730236 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.4] Fix history page iteration in backwards mode

https://gerrit.wikimedia.org/r/730236

Mentioned in SAL (#wikimedia-operations) [2021-10-12T17:23:31Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/includes/actions/pagers/HistoryPager.php: Backport: [[gerrit:730236|Fix history page iteration in backwards mode (T292791)]] (duration: 00m 57s)

dancy claimed this task.