Page MenuHomePhabricator
Create Task
Maniphest T292889

Display errors to the user when the try to publish an edit to a function
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Go to Notwikilambda
  • Create a new function
  • Don't be logged in
  • Try to save by clicking save

What happens?:
Nothing

What should have happened instead?:
It should save.

I assume nothing happens because we are not logged in and thus are not allowed to save. But the error message is not being reported in the Function Editor.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Display errors to the user when the try to publish an edit to a functionmediawiki/extensions/WikiLambdamaster+23 -20
Customize query in gerrit

Event Timeline

DVrandecic created this task.Oct 9 2021, 1:59 AM
DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Oct 13 2021, 4:21 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF renamed this task from Function editor: errors on save are not reported to Display errors to the user when the try to publish an edit to a function.Mar 8 2022, 11:10 PM
Jdforrester-WMF added a project: WikiLambda Front-end.
Jdforrester-WMF moved this task from Incoming to Needs discussion/DoD on the Abstract Wikipedia team (Phase θ – Throttling) board.
DVrandecic added a comment.Mar 13 2022, 2:39 PM

I checked, and this still happens.

• AdesojiThisDot changed the task status from Open to In Progress.Mar 15 2022, 3:42 PM
• AdesojiThisDot claimed this task.
• AdesojiThisDot moved this task from Phase θ – Throttling to Phase η – Generic types on the Abstract Wikipedia team board.
• AdesojiThisDot edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team (Phase θ – Throttling).
• AdesojiThisDot moved this task from Incoming to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team (Phase η – Generic types).Mar 17 2022, 6:08 PM
gerritbot added a comment.Mar 22 2022, 3:30 PM

Change 772867 had a related patch set uploaded (by AdesojiThisDot; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] Display errors to the user when the try to publish an edit to a function

https://gerrit.wikimedia.org/r/772867

gerritbot added a project: Patch-For-Review.Mar 22 2022, 3:30 PM
gerritbot added a comment.Mar 24 2022, 2:28 PM

Change 772867 had a related patch set uploaded (by Jforrester; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] Display errors to the user when the try to publish an edit to a function

https://gerrit.wikimedia.org/r/772867

gerritbot added a comment.Mar 24 2022, 8:07 PM

Change 772867 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Display errors to the user when the try to publish an edit to a function

https://gerrit.wikimedia.org/r/772867

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 24 2022, 9:00 PM
Jdforrester-WMF closed this task as Resolved.Apr 6 2022, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits