Page MenuHomePhabricator
Create Task
Maniphest T292987

Move Content::getParserOutput method that don't belong in Content to ContentHandler
Closed, ResolvedPublic
Actions

Description

We moved Content methods ::getParserOutput and ::fillParserOutput to ContentHandler on core Patch

So we also need to do it with XmlContent content that extend it in examples extension.
The idea is to override method fillParserOutput in XmlContentHandler and move implementation of XmlContent::getParserOutput.

Details

SubjectRepoBranchLines +/-
Override ContentHandler::fillParserOutput instead of Content::getParserOutput and TextContent::getHtml().mediawiki/extensions/examplesmaster+23 -37
Customize query in gerrit

Related Objects

Event Timeline

roman-stolar created this task.Oct 11 2021, 1:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2021, 1:09 PM
roman-stolar updated the task description. (Show Details)Oct 11 2021, 1:24 PM
roman-stolar claimed this task.Oct 21 2021, 3:20 PM
roman-stolar triaged this task as High priority.Oct 21 2021, 3:23 PM
roman-stolar moved this task from Not deployed extensions to Doing on the Platform Team Workboards (MW Expedition) board.
gerritbot added a comment.Oct 21 2021, 3:48 PM

Change 732727 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/examples@master] Override ContentHandler::fillParserOutput instead of Content::getParserOutput and TextContent::getHtml().

https://gerrit.wikimedia.org/r/732727

gerritbot added a project: Patch-For-Review.Oct 21 2021, 3:48 PM
gerritbot added a comment.Oct 21 2021, 5:05 PM

Change 732727 merged by jenkins-bot:

[mediawiki/extensions/examples@master] Override ContentHandler::fillParserOutput instead of Content::getParserOutput and TextContent::getHtml().

https://gerrit.wikimedia.org/r/732727

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2021, 5:11 PM
roman-stolar moved this task from Doing to Waiting for release on the Platform Team Workboards (MW Expedition) board.Oct 27 2021, 8:19 AM
roman-stolar moved this task from Waiting for release to On the train on the Platform Team Workboards (MW Expedition) board.
Aklapper mentioned this in T287158: Move Content::getParserOutput method that don't belong in Content to ContentHandler.Oct 9 2023, 1:30 PM
Aklapper closed this task as Resolved.Oct 9 2023, 1:36 PM

Patch was merged two years ago; assuming this is resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL