Page MenuHomePhabricator
Create Task
Maniphest T293007

Create tests for ZObjectFactory creation methods
Closed, ResolvedPublic
Actions

Description

Tests for create, createPersistentContent, createChild and createCustom

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add ZObjectFactory tests for all creation methodsmediawiki/extensions/WikiLambdamaster+366 -26
Add ZObjectFactory tests for all creation methodsmediawiki/extensions/WikiLambdamaster+369 -19
Customize query in gerrit

Event Timeline

gengh created this task.Oct 11 2021, 2:34 PM
Aklapper added a project: WikiLambda.Oct 12 2021, 6:51 AM
Aklapper removed a subscriber: WikiLambda.
gerritbot added a comment.Oct 13 2021, 3:35 PM

Change 730554 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add ZObjectFactory tests for all creation methods

https://gerrit.wikimedia.org/r/730554

gerritbot added a project: Patch-For-Review.Oct 13 2021, 3:35 PM
DVrandecic moved this task from To Triage to Phase η – Generic types on the Abstract Wikipedia team board.Oct 13 2021, 4:26 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
gerritbot added a comment.Oct 19 2021, 12:58 PM

Change 731966 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add ZObjectFactory tests for all creation methods

https://gerrit.wikimedia.org/r/731966

gerritbot added a comment.Oct 19 2021, 12:59 PM

Change 730554 abandoned by Genoveva Galarza:

[mediawiki/extensions/WikiLambda@master] Add ZObjectFactory tests for all creation methods

Reason:

Cherry picking this commit, too many files to rebase.

https://gerrit.wikimedia.org/r/730554

Jdforrester-WMF triaged this task as High priority.Oct 19 2021, 3:59 PM
gerritbot added a comment.Oct 19 2021, 6:41 PM

Change 731966 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add ZObjectFactory tests for all creation methods

https://gerrit.wikimedia.org/r/731966

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 19 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 19 2021, 7:10 PM
Jdforrester-WMF closed this task as Resolved.Oct 19 2021, 7:47 PM
Jdforrester-WMF subscribed.

Coverage isn't perfect, but it's non-zero: https://doc.wikimedia.org/cover-extensions/WikiLambda/includes/ZObjectFactory.php.html

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits