Infobox (accordion) is inserted before partial block notice [M]
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	phuedx
	Oct 11 2021, 4:02 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Install IP Info as described at https://www.mediawiki.org/wiki/Extension:IPInfo#Installation
Log in to the wiki as a user than partially block the IP address $ip
Enable the IP Info tool via /wiki/Special:Preferences
Create a
Navigate to /wiki/Special:Contributions/$ip

What happens?:

What should have happened instead?:

The infobox (accordion) should be inserted after the notice that the IP is affected by a partial block.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

mediawiki/extensions/IPInfo @ 9cdcf04a207ba6647bd8c8455666e58eb08d2911
mediawiki/core @ ce1c6b700208b2f7b661a769c2a174563591dbe7

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
hooks: Fix infobox expanded state regression	mediawiki/extensions/IPInfo	master	+1 -1
Insert info block after partial block notice	mediawiki/core	master	+34 -0
Insert info box after partial block notice	mediawiki/extensions/IPInfo	master	+10 -13

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		kostajh	T285977 IP Info
Resolved		kostajh	T287647 [Epic] IP Information accordion on Special:Contribs
Resolved	BUG REPORT	• TThoabala	T293011 Infobox (accordion) is inserted before partial block notice [M]

Event Timeline

phuedx created this task.Oct 11 2021, 4:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2021, 4:02 PM

/cc @Niharika

Good catch. Do we know if this is true only for the partial block banner?

Niharika added a project: Anti-Harassment-Team.Oct 11 2021, 6:58 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.

In T293011#7418122, @Niharika wrote:

Good catch. Do we know if this is true only for the partial block banner?

After a little bit of reading of the file that backs the Special:Contributions special page, yes.

The [partial] block banner is inserted after the SpecialPageBeforeExecute hook is run, which we hook into in order to insert the infobox (accordion) into the special pages that we're targeting. There's a more specific hook run on that page just before the "Search for contributions" form is added to the page, SpecialContributionsBeforeMainOutput, which we should investigate.

ARamirez_WMF renamed this task from Infobox (accordion) is inserted before partial block notice to Infobox (accordion) is inserted before partial block notice [M].Oct 13 2021, 4:38 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.

Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment-Team board.Oct 13 2021, 4:57 PM

Niharika edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.

• TThoabala claimed this task.Oct 22 2021, 4:23 PM

• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.Oct 25 2021, 9:36 AM

Change 735397 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Insert info box after partial block notice - IPInfo

https://gerrit.wikimedia.org/r/735397

Change 735398 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/core@master] Insert info block after partial block notice

https://gerrit.wikimedia.org/r/735398

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Oct 28 2021, 2:49 PM

There's a more specific hook run on that page just before the "Search for contributions" form is added to the page, SpecialContributionsBeforeMainOutput, which we should investigate.

To expand a little on this...

This hook is run here. Looks like it should be possible to use this hook instead of SpecialPageBeforeExecute. See InfoBoxHandler.php where we handle that hook - we should be able to replace the handler onSpecialPageBeforeExecute with a handler onSpecialContributionsBeforeMainOutput, which does pretty much the same thing.

SpecialContributionsBeforeMainOutput is documented here. We should be able to use $user to find the IP address, and $sp to get the special page context, particularly the OutputPage.

Here's some info on how hooks work in MediaWiki: https://www.mediawiki.org/wiki/Manual:Hooks - see in particular https://www.mediawiki.org/wiki/Manual:Hooks#Handling_hooks_in_MediaWiki_1.35_and_later

• TThoabala moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.Nov 1 2021, 3:49 PM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Nov 2 2021, 9:24 PM

phuedx moved this task from Backlog to In Progress on the IP Info board.Nov 5 2021, 4:38 PM

Change 735397 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Insert info box after partial block notice

https://gerrit.wikimedia.org/r/735397

• TThoabala mentioned this in rEIPIbf948f0bf2c3: Insert info box after partial block notice.Nov 8 2021, 4:33 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Nov 8 2021, 4:48 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 8 2021, 5:00 PM

I have confirmed that issue is fixed and I tested on supported browsers(FF, Chrome, Safari, Opera, Edge and IE)
Note: Also confirmed that when a user has been unblocked, the warming message no long shows on the IP contributions page.

Testing Screen shots:

Screen Shot 2021-11-09 at 1.13.22 PM.png (1×2 px, 662 KB)

Screen Shot 2021-11-09 at 1.18.22 PM.png (1×2 px, 556 KB)

Screen Shot 2021-11-09 at 1.36.51 PM.png (1×2 px, 2 MB)

• imaigwilo moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment-Team (The Letter Song) board.Nov 9 2021, 7:19 PM

Change 735398 abandoned by TsepoThoabala:

[mediawiki/core@master] Insert info block after partial block notice

Reason:

Change merged on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/735397/

https://gerrit.wikimedia.org/r/735398

Maintenance_bot removed a project: Patch-For-Review.Nov 11 2021, 11:10 AM

Niharika closed this task as Resolved.Nov 11 2021, 8:56 PM

Change 740926 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/IPInfo@master] hooks: Fix infobox expanded state regression

https://gerrit.wikimedia.org/r/740926

gerritbot added a project: Patch-For-Review.Nov 23 2021, 8:11 PM

Change 740926 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] hooks: Fix infobox expanded state regression

https://gerrit.wikimedia.org/r/740926

Maintenance_bot removed a project: Patch-For-Review.Nov 23 2021, 9:10 PM

phuedx mentioned this in T288718: Spike: IP Info accordion: Shows both expand and collapse icons on mobile web [16 H].Dec 10 2021, 11:02 AM

Niharika moved this task from In Progress to Closed on the IP Info board.Aug 4 2022, 3:51 PM

	F34739508: Screen Shot 2021-11-09 at 1.18.22 PM.png
	Nov 9 2021, 7:18 PM

	F34739509: Screen Shot 2021-11-09 at 1.36.51 PM.png
	Nov 9 2021, 7:18 PM

	F34739507: Screen Shot 2021-11-09 at 1.13.22 PM.png
	Nov 9 2021, 7:18 PM

Infobox (accordion) is inserted before partial block notice [M]Closed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Infobox (accordion) is inserted before partial block notice [M]
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...