Improve log-out process in Minerva skin
Closed, ResolvedPublic3 Estimated Story PointsFeature
Actions

Assigned To

Authored By

	Sdkb
	Oct 11 2021, 8:12 PM

Description

Original report

Summary: the logout button currently doesn't have a label, and potential confusion can lead to unintended logouts.

Wikipedia_mobile_side_menu.jpg (2×1 px, 114 KB)

I recently decided to try turning off advanced mode on mobile (Android, the en.m.wikipedia.org site, not the app). In the menu, pictured above, I noticed an icon next to my username that connoted something vaguely external, and I figured I'd tap on it to see what it was.
And WHAM. I'm instantly logged out of my account, and now I have to log in again for all my tabs and all the Wikimedia sites everywhere. Could you please add a basic confirmation step to stop this sort of thing from happening? See T217914 for a related issue.

Design

QA Results - Prod

AC	Status	Details
1	✅	T293041#7579230

Details

	Subject	Repo	Branch	Lines +/-
	Remove primary/secondary menu items, instead add a separate log out menu item	mediawiki/skins/MinervaNeue	master	+19 -36

Customize query in gerrit

Related Objects

Mentioned Here: T217914: Prevent accidental logouts on desktop Vector skin when using a mobile device

Event Timeline

Sdkb created this task.Oct 11 2021, 8:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2021, 8:12 PM

Sdkb updated the task description. (Show Details)Oct 11 2021, 8:13 PM

@Sdkb: Thanks for reporting this. For future reference, please use the feature request form (linked from the top of the task creation page) to create feature requests. Thanks.

Jdlrobson renamed this task from Add confirmation for log-out button on mobile to Add confirmation for log-out button on Minerva skin.Oct 12 2021, 6:05 PM

Jdlrobson edited projects, added MinervaNeue; removed MobileFrontend.

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 12 2021, 6:05 PM

Jdlrobson added a project: Web-Team-Backlog.Oct 12 2021, 6:06 PM

ovasileva subscribed.Oct 12 2021, 7:27 PM

@alexhollender - any thoughts on this one? I think there's also a similar request for an additional step on desktop as well

ovasileva moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Oct 12 2021, 9:10 PM

@ovasileva I agree that the log out action is not clear. I wonder if we should improve the button before adding a confirmation step?

A	B

ovasileva triaged this task as Medium priority.Oct 18 2021, 8:01 PM

ovasileva renamed this task from Add confirmation for log-out button on Minerva skin to Improve log-out process in Minerva skin.Oct 18 2021, 8:04 PM

ovasileva updated the task description. (Show Details)

ovasileva assigned this task to • alexhollender_WMF.Oct 18 2021, 8:08 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

In T293041#7425122, @alexhollender wrote:

@ovasileva I agree that the log out action is not clear. I wonder if we should improve the button before adding a confirmation step?

A B

I think B creates a clearer organization/hierarchy of the links

In T293041#7446000, @ovasileva wrote:

In T293041#7425122, @alexhollender wrote:

@ovasileva I agree that the log out action is not clear. I wonder if we should improve the button before adding a confirmation step?

A B

I think B creates a clearer organization/hierarchy of the links

Thanks @alexhollender for the ping. I agree moving the logout as a separate button (and separate the tap target cell from username) is a good first step before the more drastic addition of a confirm dialog. As for the two options, agree with @ovasileva that B is a clearer hierarchy. Particularly, having the "Donate" button between user pages and logout in A could incorrectly imply that donating is connected to one's account when it's not.

• alexhollender_WMF removed • alexhollender_WMF as the assignee of this task.Oct 21 2021, 1:19 PM

• alexhollender_WMF updated the task description. (Show Details)

Sounds like the basic proposal here is to make the non-AMC mode behave like AMC.
Looks like a straightforward change that will remove some AMC-specific code.

In T293041#7452071, @Jdlrobson wrote:

Sounds like the basic proposal here is to make the non-AMC mode behave like AMC.
Looks like a straightforward change that will remove some AMC-specific code.

@Jdlrobson - I think for AMC, the logout is in the user menu:

Screen Shot 2021-10-22 at 2.36.23 PM.png (884×974 px, 287 KB)

Thanks for the correction. The logout menu item is the only one which has 2 links in it so this change should still simplify a few things. There's some CSS code we can remove with this change and no caching risk since this is logged in only.

Jdlrobson set the point value for this task to 3.Oct 25 2021, 5:45 PM

Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

bwang claimed this task.Nov 2 2021, 4:58 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 736539 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Remove primary/secondary menu items, instead add a separate log out menu item

https://gerrit.wikimedia.org/r/736539

gerritbot added a project: Patch-For-Review.Nov 3 2021, 5:19 PM

bwang removed bwang as the assignee of this task.Nov 3 2021, 5:26 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

bwang subscribed.

@alexhollender for non-AMC:

For anons:

Screen Shot 2021-11-03 at 12.08.36 PM.png (784×1 px, 74 KB)

For logged in:

Screen Shot 2021-11-03 at 12.09.02 PM.png (1×1 px, 105 KB)

Your mock groups settings with username, watchlist and contributions. Given settings works for anonymous users I'm wondering if that grouping makes sense for anons anymore.

For consistency wouldn't settings appear above log in for anons with this new design?

Alternatively, we could keep settings unchanged by this change and add logout under contributions.

@alexhollender Similar question to @Jdlrobson, should we also update the menu for AMC users for consistency? It currently looks like this: https://jmp.sh/Tx8cjcI

Jdlrobson moved this task from Code Review to Design Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Nov 4 2021, 9:57 PM

@Jdlrobson @bwang my preference would be to leave AMC and logged-out menus as is

@alexhollender @bwang can I confirm this is what we are proposing: ?

Anon	Logged in	AMC

In T293041#7493457, @Jdlrobson wrote:

@alexhollender @bwang can I confirm this is what we are proposing: ?

Anon Logged in AMC

yes looks good

bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Nov 12 2021, 8:13 PM

LGoto assigned this task to Jdrewniak.Nov 16 2021, 6:15 PM

Jdrewniak reassigned this task from Jdrewniak to Edtadros.Nov 18 2021, 6:21 PM

Jdrewniak moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdrewniak subscribed.

Change 736539 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove primary/secondary menu items, instead add a separate log out menu item

https://gerrit.wikimedia.org/r/736539

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 19 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 19 2021, 6:11 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Logout should look like the mockups in T293041#7493457

Anon	Logged in	AMC

Edtadros updated the task description. (Show Details)Dec 18 2021, 7:29 PM

Looks good!

	F34888598: en.m.wikipedia.org_w_index.php_title=Special_UserLogout&returnto=Special%3AMobileOptions&returntoquery=success%3D(iPhone 11 Pro Max).png
	Dec 18 2021, 7:28 PM

	F34888595: en.m.wikipedia.org_w_index.php_title=Special_MobileOptions&success(iPhone 11 Pro Max) (1).png
	Dec 18 2021, 7:28 PM

	F34888594: en.m.wikipedia.org_w_index.php_title=Special_MobileOptions&success(iPhone 11 Pro Max).png
	Dec 18 2021, 7:28 PM

	F34888592: en.m.wikipedia.org_wiki_Special_EditWatchlist(iPhone 11 Pro Max).png
	Dec 18 2021, 7:28 PM

	F34739482: Screen Shot 2021-11-09 at 10.54.12 AM.png
	Nov 9 2021, 6:55 PM

	F34739487: Screen Shot 2021-11-09 at 10.55.01 AM.png
	Nov 9 2021, 6:55 PM

	F34739489: Screen Shot 2021-11-09 at 10.55.18 AM.png
	Nov 9 2021, 6:55 PM

	F34739480: Screen Shot 2021-11-09 at 10.53.13 AM.png
	Nov 9 2021, 6:55 PM

Improve log-out process in Minerva skinClosed, ResolvedPublic3 Estimated Story PointsFeatureActions