Page MenuHomePhabricator
Create Task
Maniphest T293050

Characters are missing in the chart of EasyTimeline on zhwiki
Closed, ResolvedPublicBUG REPORT
Actions

Description

What happens?:
As the title says, the chart rendered by zhwiki's EasyTimeline has missing characters.

example：
Template:監督員任期時間線

EasyTimeline.png (323×923 px, 11 KB)

What should have happened instead?:
Of course, the characters are rendered normally.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Just like the mediawiki production environment version used by wikimedia.

T22825 : This task has solved the long-standing EasyTimeline rendering character loss problem. It seems that the font file of a certain application server is missing. It may be a reference.

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+1 -1Update $wgTimelineFonts for new path to unifont in Shellbox container
mediawiki/libs/Shellboxmaster+1 -1pipeline: Rename unifont to "unifont.ttf" to please ploticus
Customize query in gerrit

Related Objects
Search...

Event Timeline

Cwek created this task.Oct 12 2021, 1:09 AM
Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptOct 12 2021, 1:09 AM
Cwek updated the task description. (Show Details)Oct 12 2021, 1:10 AM
Cwek updated the task description. (Show Details)
Shizhao moved this task from Backlog to Extensions/Skins on the Chinese-Sites board.Oct 12 2021, 2:02 AM
Aklapper closed this task as a duplicate of T188997: Change EasyTimeline's font on yue Wikipedia with support for Chinese characters.Oct 12 2021, 6:14 AM
Ericliu1912 added a subscriber: Ericliu1912.Oct 12 2021, 6:37 AM
Cwek reopened this task as Open.Oct 12 2021, 7:07 AM

@Aklapper
Negative! T188997 is about zh-yue wiki. It's NOT for zhwiki. According to the report in the technical discussion section, the problem seems to have been discovered on October 1, 2021.

VulpesVulpes825 added projects: Wikimedia-Site-requests, Wikimedia-production-error.Oct 12 2021, 8:13 PM
VulpesVulpes825 added a subscriber: VulpesVulpes825.

This might be an issue with operations/mediawiki-config, causing the font files not linked for display.

Krinkle removed a project: Wikimedia-production-error.Oct 13 2021, 6:11 PM
TheDJ added a subscriber: TheDJ.Oct 20 2021, 1:52 PM

Wasn't easy timeline moved to Shellbox ? Probably those Kubernetes hosts don't have the entire set of fonts they require I guess ?

VulpesVulpes825 added a parent task: T289226: Convert EasyTimeline extension to use Shellbox.Oct 20 2021, 5:41 PM
VulpesVulpes825 edited projects, added Shellbox, Regression; removed Wikimedia-Site-requests.Oct 20 2021, 5:46 PM
In T293050#7444425, @TheDJ wrote:

Wasn't easy timeline moved to Shellbox ? Probably those Kubernetes hosts don't have the entire set of fonts they require I guess ?

This suggest solution from T22825 needs to implement in the Kubernetes host based on solution from T274822

Legoktm claimed this task.Oct 20 2021, 6:00 PM
Legoktm added a subscriber: Legoktm.

Something is wrong with the special unifont for zh wikis, when I switch that timeline to use a different font (|font=freesanswmf) it partially displays.

unifont is installed in the container:

km@cashew ~/g/o/puppet> podman run --rm -it --entrypoint=bash --user=root docker-registry.wikimedia.org/wikimedia/mediawiki-libs-shellbox:timeline
root@fc7084afe8ed:/srv/app# ls fonts/
FreeSans.ttf  FreeSansWMF.ttf  unifont-5.1.20080907.ttf

and afaict configured properly on the MW side;

legoktm@mwmaint1002:~$ mwscript shell.php --wiki=zhwiki
Psy Shell v0.10.8 (PHP 7.2.34-18+0~20210223.60+debian10~1.gbpb21322+wmf2 — cli) by Justin Hileman
>>> return $wgTimelineFonts
=> [
     "freesans" => "/srv/app/fonts/FreeSans",
     "freesanswmf" => "/srv/app/fonts/FreeSansWMF",
     "unifont" => "/srv/app/fonts/unifont-5.1.20080907",
     "default" => "/srv/app/fonts/unifont-5.1.20080907",
   ]

I'll keep digging...

Legoktm added a comment.Oct 21 2021, 6:35 PM

For some reason, ploticus does not like the name of "unifont-5.1.20080907.ttf". When I renamed it to "unifont.ttf" it became happy. This makes no sense to me because it's always been called that and it's not like we switch gd or ploticus versions or anything.

gerritbot added a comment.Oct 21 2021, 6:42 PM

Change 732759 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/libs/Shellbox@master] pipeline: Rename unifont to \"unifont.ttf\" to please ploticus

https://gerrit.wikimedia.org/r/732759

gerritbot added a project: Patch-For-Review.Oct 21 2021, 6:42 PM

Change 732761 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/mediawiki-config@master] Update $wgTimelineFonts for new path to unifont in Shellbox container

https://gerrit.wikimedia.org/r/732761

gerritbot added a comment.Oct 21 2021, 7:05 PM

Change 732759 merged by jenkins-bot:

[mediawiki/libs/Shellbox@master] pipeline: Rename unifont to \"unifont.ttf\" to please ploticus

https://gerrit.wikimedia.org/r/732759

gerritbot added a comment.Oct 21 2021, 7:37 PM

Change 732761 merged by jenkins-bot:

[operations/mediawiki-config@master] Update $wgTimelineFonts for new path to unifont in Shellbox container

https://gerrit.wikimedia.org/r/732761

TheDJ added a comment.EditedOct 21 2021, 7:40 PM
In T293050#7449175, @Legoktm wrote:

For some reason, ploticus does not like the name of "unifont-5.1.20080907.ttf". When I renamed it to "unifont.ttf" it became happy. This makes no sense to me because it's always been called that and it's not like we switch gd or ploticus versions or anything.

@Legoktm
Does ploticus also use fontconfig/freetype2 ? Because I remember from a very long time ago that if you don't have correct fontconfig or didn't run fc-cache at least once, that font name resolving would break exactly like this. (We used to have this problem with VLC media player like a bazillion years ago).

Just a thought, thx for fixing this!

Stashbot added a comment.Oct 21 2021, 7:42 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-21T19:42:40Z] <legoktm@deploy1002> Synchronized wmf-config/CommonSettings.php: Update $wgTimelineFonts for new path to unifont in Shellbox container (T293050) (duration: 00m 55s)

Legoktm closed this task as Resolved.Oct 21 2021, 7:49 PM

Screenshot 2021-10-21 at 12-34-58 Template 監督員任期時間線 - Wikipedia.png (941×2 px, 126 KB)

The fixed timelines should show up right away, if not a purge should do it. Sorry about not catching/testing this earlier.

In T293050#7449354, @TheDJ wrote:
In T293050#7449175, @Legoktm wrote:

For some reason, ploticus does not like the name of "unifont-5.1.20080907.ttf". When I renamed it to "unifont.ttf" it became happy. This makes no sense to me because it's always been called that and it's not like we switch gd or ploticus versions or anything.

@Legoktm
Does ploticus also use fontconfig/freetype2 ? Because I remember from a very long time ago that if you don't have correct fontconfig or didn't run fc-cache at least once, that font name resolving would break exactly like this. (We used to have this problem with VLC media player like a bazillion years ago).

I think ploticus just delegates all the font stuff to gd, I kind of don't want to look in the ploticus source code. But even on appservers, I don't see any place we install the fontconfig for unifont, it was just the ttf file that was copied into git.

legoktm@mwdebug1001:~$ fc-match unifont
DejaVuSans.ttf: "DejaVu Sans" "Book"

However, I wouldn't be surprised if it ended up being something like us not running fc-cache in the container while something else makes it run on appservers and that's what has magically made it work this entire time.

Just a thought, thx for fixing this!

:)

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2021, 8:10 PM
VulpesVulpes825 moved this task from Extensions/Skins to Closed on the Chinese-Sites board.Oct 21 2021, 10:50 PM

@Legoktm Thanks for fixing this!

Cwek awarded a token.Oct 26 2021, 3:54 AM
Stang awarded a token.Nov 1 2021, 8:23 PM
Stang removed a subscriber: Stang.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL