Page MenuHomePhabricator

[Insert link] Hidden icon element is visible and prevents text-selection
Closed, ResolvedPublic

Description

The hidden noIcon OOUI element has been given a dispaly: inline inline style, and is in front of the text input, obscuring the text for selection.

Steps to reproduce

  1. Open the editing interface for any page
  2. From the toolbar above the editing area, open the "insert link" dialog (the one with the "link" icon)
  3. Add some text in both fields
  4. With your mouse, try to select text in those fields

In particular, the observed behaviour was that you could not start the selection from the first letter or two. Selecting other text worked, but clicking on the first letter didn't clear the selection.

Event Timeline

Change 730152 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/WikiEditor@master] Remove 'resize' logic from jQuery UI dialogs

https://gerrit.wikimedia.org/r/730152

Change 730152 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Remove 'resize' logic from jQuery UI dialogs

https://gerrit.wikimedia.org/r/730152

Daimona updated the task description. (Show Details)
Daimona moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-11) board.
dom_walden subscribed.

In particular, the observed behaviour was that you could not start the selection from the first letter or two. Selecting other text worked, but clicking on the first letter didn't clear the selection.

I cannot reproduce these two issues on beta.

I briefly confirmed that the basic functionality of Insert Link still works - I can use it to add a link in the wikitext editor.

Test environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.38.0-alpha (df729bc) 23:52, 14 October 2021.

NRodriguez subscribed.

Could also not reproduce on beta, insert link still works