Page MenuHomePhabricator
Create Task
Maniphest T293072

Refactor Popups WebdriverIO tests from sync to async mode
Closed, ResolvedPublic
Actions

Description

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
selenium: Refactor WebdriverIO tests from sync to async modemediawiki/extensions/Popupsmaster+1 K -1 K
WIP selenium: Refactor WebdriverIO tests from sync to async modemediawiki/extensions/Popupsmaster+3 K -1 K
selenium: Refactor WebdriverIO tests from sync to async modemediawiki/extensions/Popupsmaster+942 -794
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Oct 12 2021, 12:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2021, 12:32 PM
zeljkofilipin updated the task description. (Show Details)Oct 12 2021, 12:34 PM
zeljkofilipin added a parent task: T256626: Refactor WebdriverIO tests from sync to async mode.
zeljkofilipin mentioned this in T256626: Refactor WebdriverIO tests from sync to async mode.
Osamaahmed17 subscribed.Oct 12 2021, 3:06 PM
zeljkofilipin assigned this task to Osamaahmed17.Dec 22 2021, 4:52 PM
zeljkofilipin triaged this task as Medium priority.
Izno moved this task from Unsorted backlog to Parsoid/VE implementation on the Cite board.Dec 23 2021, 7:23 PM
Osamaahmed17 renamed this task from Refactor Cite WebdriverIO tests from sync to async mode to Refactor Popups WebdriverIO tests from sync to async mode.Jan 20 2022, 9:18 PM
Osamaahmed17 updated the task description. (Show Details)
gerritbot added a comment.Jan 20 2022, 10:21 PM

Change 755809 had a related patch set uploaded (by Osamaahmed17; author: Osamaahmed17):

[mediawiki/extensions/Popups@master] selenium: Refactor Popups WebdriverIO tests from sync to async mode

https://gerrit.wikimedia.org/r/755809

gerritbot added a project: Patch-For-Review.Jan 20 2022, 10:21 PM
Aklapper edited projects, added Page-Previews; removed Cite.Jan 26 2022, 10:35 PM
Osamaahmed17 updated the task description. (Show Details)Feb 2 2022, 9:18 PM
zeljkofilipin removed Osamaahmed17 as the assignee of this task.Feb 8 2022, 4:49 PM
zeljkofilipin raised the priority of this task from Medium to Needs Triage.
gerritbot added a comment.Nov 8 2022, 12:24 PM

Change 755809 abandoned by Zfilipin:

[mediawiki/extensions/Popups@master] selenium: Refactor WebdriverIO tests from sync to async mode

Reason:

https://gerrit.wikimedia.org/r/755809

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2022, 12:30 PM
Jdforrester-WMF mentioned this in T331063: Popups browser tests failing with `08:25:51 node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed.`.Mar 2 2023, 9:05 PM
Jdlrobson subscribed.Mar 6 2023, 7:22 PM

I'm getting regular emails about Popups tests failing ( T331063) which means I now have to manually review the logs every Monday before the train is cut. Is there a short term solution we can apply to suppress the error message reported in T331063 ?

zeljkofilipin added a subtask: T331063: Popups browser tests failing with `08:25:51 node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed.`.Mar 7 2023, 12:37 PM
zeljkofilipin added a comment.Mar 7 2023, 12:41 PM

@Jdlrobson if the Jenkins job is no longer valuable, we can delete it. If you no longer want to receive notifications when the job fails, we can remove you from the list of recipients. Long term solution is resolving this task. We are working on T256626: Refactor WebdriverIO tests from sync to async mode, but it might take us some time.

zeljkofilipin moved this task from Backlog 🪒 to Quarter 👔 on the User-zeljkofilipin board.Mar 7 2023, 12:42 PM
zeljkofilipin changed the status of subtask T331063: Popups browser tests failing with `08:25:51 node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed.` from Open to In Progress.Mar 7 2023, 4:45 PM
zeljkofilipin changed the task status from Open to In Progress.Mar 8 2023, 1:36 PM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as Low priority.
zeljkofilipin moved this task from Quarter 👔 to Deep work 🌊 on the User-zeljkofilipin board.
gerritbot added a comment.Mar 8 2023, 3:21 PM

Change 895812 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/Popups@master] WIP selenium: Refactor WebdriverIO tests from sync to async mode

https://gerrit.wikimedia.org/r/895812

gerritbot added a project: Patch-For-Review.Mar 8 2023, 3:21 PM
Jdforrester-WMF added a parent task: T330426: selenium-daily Jenkins jobs failing with `node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed`.Mar 8 2023, 8:00 PM
zeljkofilipin changed the task status from In Progress to Open.Mar 10 2023, 11:40 AM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from Low to Needs Triage.
zeljkofilipin moved this task from Deep work 🌊 to Backlog 🪒 on the User-zeljkofilipin board.
gerritbot added a comment.Mar 21 2023, 1:33 PM

Change 895812 abandoned by Zfilipin:

[mediawiki/extensions/Popups@master] WIP selenium: Refactor WebdriverIO tests from sync to async mode

Reason:

https://gerrit.wikimedia.org/r/895812

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2023, 2:10 PM
WMDE-Fisch claimed this task.Jul 18 2023, 7:38 AM
WMDE-Fisch added a project: WMDE-TechWish-Maintenance-2023.
gerritbot added a comment.Jul 18 2023, 7:38 AM

Change 939198 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Popups@master] selenium: Refactor WebdriverIO tests from sync to async mode

https://gerrit.wikimedia.org/r/939198

gerritbot added a project: Patch-For-Review.Jul 18 2023, 7:38 AM
WMDE-Fisch moved this task from Backlog to Review on the WMDE-TechWish-Maintenance-2023 board.Jul 18 2023, 7:38 AM
gerritbot added a comment.Jul 18 2023, 1:09 PM

Change 939198 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] selenium: Refactor WebdriverIO tests from sync to async mode

https://gerrit.wikimedia.org/r/939198

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 1:11 PM
zeljkofilipin added a comment.Jul 18 2023, 3:43 PM

@WMDE-Fisch can this task be resolved, or is there something left to do?

zeljkofilipin moved this task from Backlog 🪒 to Waiting 🏹 on the User-zeljkofilipin board.Jul 18 2023, 3:43 PM
WMDE-Fisch closed this task as Resolved.Jul 18 2023, 8:27 PM
WMDE-Fisch removed WMDE-Fisch as the assignee of this task.
WMDE-Fisch moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.
WMDE-Fisch subscribed.
zeljkofilipin added a comment.Jul 19 2023, 9:54 AM

🎉

zeljkofilipin mentioned this in Blog Post: Refactoring WebdriverIO Tests From Sync to Async Mode.Oct 15 2024, 9:42 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits