Maniphest T293155

Set up stylelint for Codex
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	Oct 12 2021, 10:00 PM

Tags

Referenced Files

None

Subscribers

Description

And look into whether it works properly with the PostCSS setup

Details

	Subject	Repo	Branch	Lines +/-
	build: Configure stylelint and make pass	design/codex	main	+3 K -40

Customize query in gerrit

Related Objects

Mentioned In: rDCOD90b57218aaf3: build: Configure stylelint and make pass
Mentioned Here: T293290: Determine browserslist settings for CSS support in Autoprefixer

Event Timeline

Catrope created this task.Oct 12 2021, 10:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2021, 10:00 PM

Catrope moved this task from Incoming/Requests to Ready for development on the Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board) board.Oct 12 2021, 10:00 PM

Related to the discussions around browser support (T293290), is there any way to warn for unsupported features similar to what you can do in ESLint?

Yes, 'no-unsupported-browser-features'

Change 731858 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] build: Configure stylelint and make pass

https://gerrit.wikimedia.org/r/731858

gerritbot added a project: Patch-For-Review.Oct 18 2021, 11:47 PM

Catrope claimed this task.Oct 18 2021, 11:47 PM

Catrope moved this task from Ready for development to Code Review on the Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board) board.

Catrope moved this task from Inbox to Infrastructure on the Codex board.

The attached patch configures stylelint to throw errors (not warnings) for unsupported features (based on the stylelint config in WVUI). What's considered unsupported is based on .browserslistrc, so once we decide which set of browsers to support on T293290, we can update .browserslistrc and that will control both stylelint and postcss.

Change 731858 merged by jenkins-bot:

[design/codex@main] build: Configure stylelint and make pass

https://gerrit.wikimedia.org/r/731858

Catrope mentioned this in rDCOD90b57218aaf3: build: Configure stylelint and make pass.Oct 19 2021, 2:23 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2021, 3:10 PM

This is resolved to me. The .browserslistrc update is covered in T293290 anyways.

Volker_E moved this task from Infrastructure to Done on the Codex board.Nov 10 2021, 6:00 AM