Page MenuHomePhabricator
Create Task
Maniphest T293235

Convert all "message" object to be plain Text
Closed, ResolvedPublic
Actions

Description

As an user of the application I would like the messages being passed around the application to always be of type string and not have instances of the mw.messages object being passed around

  • Refactor the MediaSearch Frontend code to just use text messages

CONTEXT: this ticket was created as a consequence of a comment raised by Timo Tijhof on the path https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaSearch/+/726147

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Convert all "message" object to be plain Textmediawiki/extensions/MediaSearchmaster+30 -30
Customize query in gerrit

Event Timeline

SimoneThisDot created this task.Oct 13 2021, 12:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 12:41 PM
SimoneThisDot claimed this task.Oct 19 2021, 10:34 AM
SimoneThisDot moved this task from Ready for Estimation to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Oct 19 2021, 10:37 AM

Change 731922 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Convert all \"message\" object to be plain Text

https://gerrit.wikimedia.org/r/731922

gerritbot added a project: Patch-For-Review.Oct 19 2021, 10:37 AM
SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Oct 19 2021, 10:38 AM
Seddon moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 20 2021, 8:36 AM
gerritbot added a comment.Oct 20 2021, 8:54 AM

Change 731922 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Convert all \"message\" object to be plain Text

https://gerrit.wikimedia.org/r/731922

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 20 2021, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 20 2021, 9:10 AM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Oct 27 2021, 10:41 PM
Etonkovidova closed this task as Resolved.Oct 27 2021, 11:09 PM
Etonkovidova subscribed.

Checked commons wmf.6 - no UI regression issues were found.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits