Page MenuHomePhabricator
Create Task
Maniphest T293247

PropertySuggester phan fails due to Wikibase refactoring
Closed, ResolvedPublic
Actions

Description

Phan of the PropertySuggester extensions fails with the following error due to the refactoring being done in T289125: Make PropertyId into an interface and introduce NumericPropertyId. Not sure if this result in any actual breakage.

10:27:00 src/GetSuggestions.php:214 PhanUndeclaredMethod Call to undeclared method \Wikibase\DataModel\Entity\PropertyId::getNumericId
10:27:00 src/Suggesters/SchemaTreeSuggester.php:175 PhanUndeclaredMethod Call to undeclared method \Wikibase\DataModel\Entity\PropertyId::getNumericId
10:27:00 src/Suggesters/SchemaTreeSuggester.php:208 PhanUndeclaredMethod Call to undeclared method \Wikibase\DataModel\Entity\PropertyId::getNumericId
10:27:00 src/Suggesters/SimpleSuggester.php:189 PhanUndeclaredMethod Call to undeclared method \Wikibase\DataModel\Entity\PropertyId::getNumericId
10:27:00 src/Suggesters/SimpleSuggester.php:220 PhanUndeclaredMethod Call to undeclared method \Wikibase\DataModel\Entity\PropertyId::getNumericId
10:27:00 src/SuggestionGenerator.php:204 PhanUndeclaredMethod Call to undeclared method \Wikibase\DataModel\Entity\PropertyId::getNumericId

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Typehint NumericPropertyId where necessarymediawiki/extensions/PropertySuggestermaster+23 -13
Customize query in gerrit

Related Objects

Event Timeline

Zabe created this task.Oct 13 2021, 1:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 1:40 PM
Lucas_Werkmeister_WMDE subscribed.Oct 13 2021, 1:41 PM

I’m guessing it will work at runtime as long as the PropertyId is actually a NumericPropertyId, but we should still fix this.

Maintenance_bot added a project: Wikidata.Oct 13 2021, 1:45 PM
Jakob_WMDE claimed this task.Oct 13 2021, 2:08 PM
gerritbot added a comment.Oct 13 2021, 2:33 PM

Change 730537 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/PropertySuggester@master] Typehint NumericPropertyId where necessary

https://gerrit.wikimedia.org/r/730537

gerritbot added a project: Patch-For-Review.Oct 13 2021, 2:33 PM
gerritbot added a comment.Oct 13 2021, 3:36 PM

Change 730537 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] Typehint NumericPropertyId where necessary

https://gerrit.wikimedia.org/r/730537

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 13 2021, 3:56 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 13 2021, 4:00 PM
Jakob_WMDE mentioned this in rEPSf06332b5de17: Typehint NumericPropertyId where necessary.Oct 13 2021, 4:02 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 13 2021, 4:10 PM
Lydia_Pintscher added subscribers: Addshore, Lydia_Pintscher.Oct 16 2021, 6:22 PM

@Addshore Does this also affect the new suggester?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits