PHP Notice: Undefined offset: 2
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	dancy
	Oct 13 2021, 3:12 PM

Description

Error

mwversion: 1.38.0-wmf.3
reqId: 659ec3b4-ff69-412f-9bc7-b75d08c6112b
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined offset: 2

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.3/extensions/Collection/includes/Specials/SpecialCollection.php(635)
#0 /srv/mediawiki/php-1.38.0-wmf.3/extensions/Collection/includes/Specials/SpecialCollection.php(635): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.38.0-wmf.3/extensions/Collection/includes/Api/ApiRenameChapter.php(38): SpecialCollection::renameChapter(integer, string)
#2 /srv/mediawiki/php-1.38.0-wmf.3/includes/api/ApiMain.php(1877): MediaWiki\Extensions\Collection\Api\ApiRenameChapter->execute()
#3 /srv/mediawiki/php-1.38.0-wmf.3/includes/api/ApiMain.php(856): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.38.0-wmf.3/includes/api/ApiMain.php(827): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.38.0-wmf.3/api.php(90): ApiMain->execute()
#6 /srv/mediawiki/php-1.38.0-wmf.3/api.php(45): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}

Notes

There have been about 100 of these errors in the last hour. Looks like someone is trying to find a vulnerability. Anyway, some defensive coding is needed to avoid the Undefined offset notice.

Details

Request URL: https://id.wikipedia.org/w/api.php?action=*&chaptername=*&index=*

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Api: Avoid trying to access undefined offset in a user's collection	mediawiki/extensions/Collection	master	+42 -2
Api: Avoid trying to access undefined offset in a user's collection	mediawiki/extensions/Collection	wmf/1.38.0-wmf.3	+6 -1
Api: Avoid trying to access undefined offset in a user's collection	mediawiki/extensions/Collection	wmf/1.38.0-wmf.4	+42 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dancy	T281168 1.38.0-wmf.4 deployment blockers
		Resolved	PRODUCTION ERROR	xSavitar	T293261 PHP Notice: Undefined offset: 2

Event Timeline

dancy created this task.Oct 13 2021, 3:12 PM

dancy triaged this task as High priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 3:12 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Collection/+/722934

cc @xSavitar

Change 730563 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/Collection@master] Api: Avoid trying to access undefined offset in a user's collection

https://gerrit.wikimedia.org/r/730563

gerritbot added a project: Patch-For-Review.Oct 13 2021, 3:45 PM

Krinkle moved this task from Untriaged to Oct 2021 on the Wikimedia-production-error board.Oct 13 2021, 6:08 PM

Krinkle added a project: Unstewarded-production-error.Oct 13 2021, 6:11 PM

Change 730563 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Api: Avoid trying to access undefined offset in a user's collection

https://gerrit.wikimedia.org/r/730563

Change 730577 had a related patch set uploaded (by Zabe; author: Derick Alangi):

[mediawiki/extensions/Collection@wmf/1.38.0-wmf.4] Api: Avoid trying to access undefined offset in a user's collection

https://gerrit.wikimedia.org/r/730577

Change 730578 had a related patch set uploaded (by Zabe; author: Derick Alangi):

[mediawiki/extensions/Collection@wmf/1.38.0-wmf.3] Api: Avoid trying to access undefined offset in a user's collection

https://gerrit.wikimedia.org/r/730578

Change 730577 merged by jenkins-bot:

[mediawiki/extensions/Collection@wmf/1.38.0-wmf.4] Api: Avoid trying to access undefined offset in a user's collection

https://gerrit.wikimedia.org/r/730577

Mentioned in SAL (#wikimedia-operations) [2021-10-13T21:50:15Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/Collection: Backport: [[gerrit:730577|Api: Avoid trying to access undefined offset in a user's collection (T293261)]] (duration: 01m 04s)

Change 730578 merged by jenkins-bot:

[mediawiki/extensions/Collection@wmf/1.38.0-wmf.3] Api: Avoid trying to access undefined offset in a user's collection

https://gerrit.wikimedia.org/r/730578

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 13 2021, 10:00 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-13T22:01:16Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.3/extensions/Collection/includes/Specials/SpecialCollection.php: Backport: [[gerrit:730578|Api: Avoid trying to access undefined offset in a user's collection (T293261)]] (duration: 01m 04s)

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2021, 10:10 PM

Should be fixed, please reopen if not.

Restricted Application added a project: User-xSavitar. · View Herald TranscriptOct 13 2021, 10:11 PM

dancy added a parent task: T281168: 1.38.0-wmf.4 deployment blockers.Oct 13 2021, 10:14 PM

PHP Notice: Undefined offset: 2Closed, ResolvedPublicPRODUCTION ERRORActions