Newcomers Homepage "Ask your mentor" dialog isn't tall enough
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	valcio
	Oct 13 2021, 3:15 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Open the Italian WIkipedia
Enable the homepage from your preferences
Open the newcomers' homepage
Press the "Ask your mentor" button

What happens?:
The dialog appears, but it isn't high enough: the multiline text input widget is partially hidden and an ugly scrolling bar appears.

This doesn't depend on the language but on the wiki.

What should have happened instead?:
It is working properly on frwiki and testwiki, see:

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Italian Wikipedia, Chrome 94.0.4606.81

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	QuestionPoster: set minimum dialog height	mediawiki/extensions/GrowthExperiments	master	+18 -3

Customize query in gerrit

Related Objects

Mentioned In: T255037: Deploy Growth features on Italian Wikipedia
Mentioned Here: T284088: Merge preference "Enable the editor help panel" with "Display the newcomer homepage" together

Event Timeline

valcio created this task.Oct 13 2021, 3:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 3:15 PM

valcio mentioned this in T255037: Deploy Growth features on Italian Wikipedia.Oct 13 2021, 3:16 PM

valcio updated the task description. (Show Details)Oct 13 2021, 3:21 PM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Oct 13 2021, 9:33 PM

• mewoph claimed this task.Oct 14 2021, 4:39 PM

• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

The dialog height is computed by OOUI when it's opened by calling getBodyHeight. The issue here is that we are currently using HelpPanelProcessDialog for the dialog content which consists of multiple panel layouts: home, ask your mentor etc. The home panel is the first panel and the height of the dialog is computed based on that (by overriding getBodyHeight) and not the ask your mentor screen, which is the one that's actually shown. This explains why in itwiki where mw.config.get( 'wgGEHelpPanelAskMentor' ) is false, the dialog is shorter than the actual content and in other wikis, the dialog is taller than the actual content.

Home panel for itwiki

Screen Shot 2021-10-14 at 9.43.41 AM.png (708×1 px, 210 KB)

Home panel for cswiki

Screen Shot 2021-10-14 at 9.48.26 AM.png (882×1 px, 100 KB)

Change 730870 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] QuestionPoster: set minimum dialog height

https://gerrit.wikimedia.org/r/730870

gerritbot added a project: Patch-For-Review.Oct 14 2021, 6:17 PM

Before:

After:

The issue is present when Help panel is not activated. T284088: Merge preference "Enable the editor help panel" with "Display the newcomer homepage" together should address it.

In T293262#7430335, @Etonkovidova wrote:

The issue is present when Help panel is not activated. T284088: Merge preference "Enable the editor help panel" with "Display the newcomer homepage" together should address it.

I do have both help panel and newcomer homepage enabled. This still happens.

In T293262#7430335, @Etonkovidova wrote:

The issue is present when Help panel is not activated. T284088: Merge preference "Enable the editor help panel" with "Display the newcomer homepage" together should address it.

It's a problem when the configuration (https://it.wikipedia.org/wiki/Speciale:EditGrowthConfig) is set to enable mentorship but Where should questions from the help panel be directed? specifies "Help desk" instead of "Mentor talk pages". The patch from Mew fixes the issue. The fix will be in itwiki on Thursday when the train reaches group2.

Change 730870 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] QuestionPoster: set minimum dialog height

https://gerrit.wikimedia.org/r/730870

kostajh renamed this task from Newcomers Homepage "Ask your mentor" dialog isn't heigh enough to Newcomers Homepage "Ask your mentor" dialog isn't tall enough.Oct 18 2021, 12:34 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2021, 1:10 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 18 2021, 3:00 PM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 18 2021, 9:08 PM

Checked on itwiki wmf.5 for a new account and for enabled Homepage - the issue is fixed.

	F34688868: Screen Shot 2021-10-14 at 9.48.26 AM.png
	Oct 14 2021, 4:50 PM

	F34688864: Screen Shot 2021-10-14 at 9.43.41 AM.png
	Oct 14 2021, 4:50 PM

Newcomers Homepage "Ask your mentor" dialog isn't tall enoughClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Newcomers Homepage "Ask your mentor" dialog isn't tall enough
Closed, ResolvedPublicBUG REPORT
Actions