Page MenuHomePhabricator
Create Task
Maniphest T293264

PHP Notice: Undefined index: anontalk
Closed, ResolvedPublic
Actions

Description

Error
  • mwversion: 1.37.0-beta
normalized_message
PHP Notice: Undefined index: anontalk
exception.trace
from /srv/mediawiki/w/includes/GlobalFunctions.php(194)
#0 /srv/mediawiki/w/includes/GlobalFunctions.php(194): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/w/extensions/DarkMode/includes/Hooks.php(100): wfArrayInsertAfter(array, array, string)
#2 /srv/mediawiki/w/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\DarkMode\Hooks->onPersonalUrls(array, Title, SkinVector)
#3 /srv/mediawiki/w/includes/HookContainer/HookRunner.php(3013): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#4 /srv/mediawiki/w/includes/skins/SkinTemplate.php(655): MediaWiki\HookContainer\HookRunner->onPersonalUrls(array, Title, SkinVector)
#5 /srv/mediawiki/w/includes/skins/SkinTemplate.php(1254): SkinTemplate->buildPersonalUrls(boolean)
#6 /srv/mediawiki/w/includes/skins/SkinTemplate.php(823): SkinTemplate->buildContentNavigationUrls()
#7 /srv/mediawiki/w/includes/skins/SkinTemplate.php(288): SkinTemplate->getPortletsTemplateData()
#8 /srv/mediawiki/w/includes/skins/SkinMustache.php(79): SkinTemplate->getTemplateData()
#9 /srv/mediawiki/w/skins/Vector/includes/SkinVector.php(329): SkinMustache->getTemplateData()
#10 /srv/mediawiki/w/includes/skins/SkinMustache.php(56): SkinVector->getTemplateData()
#11 /srv/mediawiki/w/includes/skins/SkinTemplate.php(144): SkinMustache->generateHTML()
#12 /srv/mediawiki/w/includes/OutputPage.php(2644): SkinTemplate->outputPage()
#13 /srv/mediawiki/w/includes/MediaWiki.php(939): OutputPage->output(boolean)
#14 /srv/mediawiki/w/includes/MediaWiki.php(952): MediaWiki::{closure}()
#15 /srv/mediawiki/w/includes/MediaWiki.php(559): MediaWiki->main()
#16 /srv/mediawiki/w/index.php(53): MediaWiki->run()
#17 /srv/mediawiki/w/index.php(46): wfIndexMain()
#18 {main}
Impact

Unknown (logspam?)

Details

Release Version
1.37.0-beta
SubjectRepoBranchLines +/-
Fix "PHP Notice: Undefined index: anontalk"mediawiki/extensions/DarkModeREL1_37+7 -2
Fix "PHP Notice: Undefined index: anontalk"mediawiki/extensions/DarkModemaster+7 -2
Customize query in gerrit

Related Objects

Event Timeline

RhinosF1 created this task.Oct 13 2021, 3:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 3:33 PM
RhinosF1 changed the subtype of this task from "Production Error" to "Task".Oct 13 2021, 3:33 PM
Reedy moved this task from Blocker to Not a blocker on the MW-1.37-release board.Oct 19 2021, 4:36 PM
MusikAnimal subscribed.Oct 21 2021, 9:30 PM

@RhinosF1 I cannot repro in new or legacy Vector on the REL1_37 branch. Any page that uses the PersonalUrls hook should have $personal_urls with keys mytalk or anontalk, depending on whether you're logged in or not. Can you provide repro steps?

RhinosF1 added a comment.Oct 21 2021, 9:32 PM
In T293264#7449592, @MusikAnimal wrote:

@RhinosF1 I cannot repro in new or legacy Vector on the REL1_37 branch. Any page that uses the PersonalUrls hook should have $personal_urls with keys mytalk or anontalk, depending on whether you're logged in or not. Can you provide repro steps?

I can see if the logs provide any more useful information but it's just log searching when testing 1.37

Universal_Omega subscribed.Nov 22 2021, 7:16 PM
In T293264#7449592, @MusikAnimal wrote:

@RhinosF1 I cannot repro in new or legacy Vector on the REL1_37 branch. Any page that uses the PersonalUrls hook should have $personal_urls with keys mytalk or anontalk, depending on whether you're logged in or not. Can you provide repro steps?

Not if * does not have the edit permission, then this would happen. I assume that's the cause. Haven't confirmed though.

gerritbot added a comment.Dec 6 2021, 6:12 PM

Change 743936 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/extensions/DarkMode@master] [DarkMode] Fix \"PHP Notice: Undefined index: anontalk\"

https://gerrit.wikimedia.org/r/743936

gerritbot added a project: Patch-For-Review.Dec 6 2021, 6:12 PM
Universal_Omega claimed this task.Dec 6 2021, 6:18 PM
gerritbot added a comment.Dec 7 2021, 6:12 AM

Change 743941 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/extensions/DarkMode@REL1_37] Fix \"PHP Notice: Undefined index: anontalk\"

https://gerrit.wikimedia.org/r/743941

gerritbot added a comment.Dec 7 2021, 6:15 AM

Change 743936 merged by jenkins-bot:

[mediawiki/extensions/DarkMode@master] Fix \"PHP Notice: Undefined index: anontalk\"

https://gerrit.wikimedia.org/r/743936

gerritbot added a comment.Dec 7 2021, 6:19 AM

Change 743941 merged by jenkins-bot:

[mediawiki/extensions/DarkMode@REL1_37] Fix \"PHP Notice: Undefined index: anontalk\"

https://gerrit.wikimedia.org/r/743941

Universal_Omega closed this task as Resolved.Dec 7 2021, 6:20 AM
Universal_Omega mentioned this in rEDKMf31995dc75c0: Fix "PHP Notice: Undefined index: anontalk".Dec 7 2021, 6:58 AM
MusikAnimal mentioned this in rEDKM208cf7bd0431: Fix "PHP Notice: Undefined index: anontalk".Dec 7 2021, 6:58 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 7 2021, 7:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL