Page MenuHomePhabricator

Add Radio component to Codex
Closed, ResolvedPublic

Description

See T281186 for previous review of different implementations.

Wikimedia Design Style Guide links:

I would recommend we stick with the WVUI approach for Radio and Checkbox for a few reasons:

  • They require the use of v-model on the end-user side, a standard Vue pattern I would like to encourage for many form elements
  • They use a compasable that wraps v-model values so they can be reused on an input that's not at the root of the template
  • They wrap the input in a label, which gives us a11y features for free

Event Timeline

Change 731836 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] Radio: Add Radio component

https://gerrit.wikimedia.org/r/731836

Change 731836 merged by jenkins-bot:

[design/codex@main] Radio, build: Add Radio component, eslint/stylelint updates

https://gerrit.wikimedia.org/r/731836

This has been merged, but I'd like to leave this task open until @Volker_E has a chance to review the Radio component. I can handle any additional feedback in a subsequent patch.

Got reviewed and resolved successfully in initial Codex release v0.1.0-alpha.1 at 2022-02-14.