PHP Notice: Undefined index: timestamp
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	dancy
	Oct 13 2021, 7:47 PM

Description

Error

mwversion: 1.38.0-wmf.4
reqId: 98b65318-2aed-42ba-8257-12f5b53f1d78
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined index: timestamp

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.4/extensions/Collection/includes/CollectionHooks.php(461)
#0 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Collection/includes/CollectionHooks.php(461): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.38.0-wmf.4/includes/HookContainer/HookContainer.php(338): CollectionHooks::checkLastModified(array, OutputPage)
#2 /srv/mediawiki/php-1.38.0-wmf.4/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#3 /srv/mediawiki/php-1.38.0-wmf.4/includes/HookContainer/HookRunner.php(2664): MediaWiki\HookContainer\HookContainer->run(string, array)
#4 /srv/mediawiki/php-1.38.0-wmf.4/includes/OutputPage.php(781): MediaWiki\HookContainer\HookRunner->onOutputPageCheckLastModified(array, OutputPage)
#5 /srv/mediawiki/php-1.38.0-wmf.4/includes/actions/ViewAction.php(68): OutputPage->checkLastModified(string)
#6 /srv/mediawiki/php-1.38.0-wmf.4/includes/MediaWiki.php(538): ViewAction->show()
#7 /srv/mediawiki/php-1.38.0-wmf.4/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.38.0-wmf.4/includes/MediaWiki.php(925): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.38.0-wmf.4/includes/MediaWiki.php(559): MediaWiki->main()
#10 /srv/mediawiki/php-1.38.0-wmf.4/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-1.38.0-wmf.4/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

Notes

Seen after rolling group1 to wmf.4

Details

Request URL: https://mh.wikipedia.org/w/index.php?direction=*&oldid=*&title=*

	Subject	Repo	Branch	Lines +/-
	Check that the timestamp key/value is set to avoid undefined offset	mediawiki/extensions/Collection	wmf/1.38.0-wmf.4	+1 -1
	Check that the timestamp key/value is set to avoid undefined offset	mediawiki/extensions/Collection	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dancy	T281168 1.38.0-wmf.4 deployment blockers
		Resolved	PRODUCTION ERROR	dancy	T293300 PHP Notice: Undefined index: timestamp

Event Timeline

dancy created this task.Oct 13 2021, 7:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 7:47 PM

dancy added a parent task: T281168: 1.38.0-wmf.4 deployment blockers.Oct 13 2021, 7:56 PM

Change 730645 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/Collection@master] Check that the timestamp key/value is set to avoid undefined offset

https://gerrit.wikimedia.org/r/730645

gerritbot added a project: Patch-For-Review.Oct 13 2021, 9:16 PM

Zabe subscribed.Oct 13 2021, 10:14 PM

Change 730580 had a related patch set uploaded (by Daniel Kinzler; author: Derick Alangi):

[mediawiki/extensions/Collection@wmf/1.38.0-wmf.4] Check that the timestamp key/value is set to avoid undefined offset

https://gerrit.wikimedia.org/r/730580

Change 730645 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Check that the timestamp key/value is set to avoid undefined offset

https://gerrit.wikimedia.org/r/730645

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 14 2021, 8:00 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-14T15:02:44Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/Collection/includes/CollectionHooks.php: Backport: [[gerrit:730580|Check that the timestamp key/value is set to avoid undefined offset (T293300)]] (duration: 01m 03s)

In T293300#7428665, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2021-10-14T15:02:44Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/Collection/includes/CollectionHooks.php: Backport: [[gerrit:730580|Check that the timestamp key/value is set to avoid undefined offset (T293300)]] (duration: 01m 03s)

This was a mistake. [[gerrit:730580]] has not been deployed yet.

Change 730580 merged by jenkins-bot:

[mediawiki/extensions/Collection@wmf/1.38.0-wmf.4] Check that the timestamp key/value is set to avoid undefined offset

https://gerrit.wikimedia.org/r/730580

Mentioned in SAL (#wikimedia-operations) [2021-10-14T16:24:58Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/Collection/includes/CollectionHooks.php: Backport: [[gerrit:730580|Check that the timestamp key/value is set to avoid undefined offset (T293300)]] (duration: 01m 04s)