Page MenuHomePhabricator
Create Task
Maniphest T293312

Move PageConfigurationLoader::onPageSaveComplete to ConfigHooks
Closed, ResolvedPublic
Actions

Description

Functionality offered by PageConfigurationLoader::onPageSaveComplete (invalidating the config cache) should be moved to ConfigHooks, and made available for all kind of config pages GrowthExperiments has/will have.

Details

SubjectRepoBranchLines +/-
Move PageConfigurationLoader::onPageSaveComplete to ConfigHooksmediawiki/extensions/GrowthExperimentsmaster+35 -45
Customize query in gerrit

Event Timeline

Urbanecm_WMF created this task.Oct 13 2021, 9:51 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 13 2021, 9:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Oct 14 2021, 7:55 AM

Change 730694 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Move PageConfigurationLoader::onPageSaveComplete to ConfigHooks

https://gerrit.wikimedia.org/r/730694

gerritbot added a project: Patch-For-Review.Oct 14 2021, 7:55 AM
Urbanecm_WMF triaged this task as Low priority.Oct 14 2021, 7:55 AM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.
gerritbot added a comment.Oct 21 2021, 12:54 PM

Change 730694 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Move PageConfigurationLoader::onPageSaveComplete to ConfigHooks

https://gerrit.wikimedia.org/r/730694

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 21 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 21 2021, 1:10 PM
Urbanecm_WMF closed this task as Resolved.Oct 21 2021, 7:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL