EditPage.php on line 646
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	dancy
	Oct 13 2021, 10:11 PM

Description

Error

mwversion: 1.38.0-wmf.3
reqId: 6e030155-5151-4123-b214-29268de5c389
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given, called in /srv/mediawiki/php-1.38.0-wmf.3/includes/EditPage.php on line 646

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.3/includes/EditPage.php(801)
#0 /srv/mediawiki/php-1.38.0-wmf.3/includes/EditPage.php(646): EditPage->displayViewSourcePage(NULL, string)
#1 /srv/mediawiki/php-1.38.0-wmf.3/includes/actions/EditAction.php(71): EditPage->edit()
#2 /srv/mediawiki/php-1.38.0-wmf.3/includes/actions/SubmitAction.php(38): EditAction->show()
#3 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(538): SubmitAction->show()
#4 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#5 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(925): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(559): MediaWiki->main()
#7 /srv/mediawiki/php-1.38.0-wmf.3/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-1.38.0-wmf.3/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Notes

A batch of 9 of these occurred a few minutes ago.

Details

Request URL: https://my.wikipedia.org/w/index.php?action=submit&title=*

Related Objects

Mentioned Here: T301947: TypeError: Argument 5 passed to MediaWiki\EditPage\Constraint\AutoSummaryMissingSummaryConstraint::__construct() must implement interface Content, null given, called in /srv/mediawiki/php-1.38.0-wmf.21/includes/EditPage.php on line 2286
T161199: Unable to open edit page for some old revisions "PHP Fatal: Argument passed to EditPage::displayViewSourcePage() must implement interface Content"
T281400: TypeError: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given

Event Timeline

dancy created this task.Oct 13 2021, 10:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 10:11 PM

Previously:
*T281400: TypeError: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given
*T161199: Unable to open edit page for some old revisions "PHP Fatal: Argument passed to EditPage::displayViewSourcePage() must implement interface Content"

The previous two instances of this error were handled by PET, and were associated with an EditPage refactor that PET was undertaking. Might be fallout from that.

The problematic code as introduced here:
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/642481/1/includes/EditPage.php#744 in 2020.

$this->getContentObject() is assumed to return a Content instance, but it can also return null and false under some circumstances. There is a similar call to displayViewSourcePage() further up in the same method which makes the same assumption. That has been there since 2015.

I suppose the solution is to introduce appropriate error handling, though I'm not sure what exactly the appropriate handling would be here. Pinging @Cparle.

Perhaps the correct thing to do would be to move the error handling code from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/683390/2/includes/EditPage.php#816 into getContentObject, so that it will always return a Content instance (or throw).

dancy unsubscribed.Nov 15 2021, 4:26 PM

CBogen added a project: Structured-Data-Backlog.Nov 15 2021, 5:50 PM

CBogen moved this task from Triage to Tracking on the Structured-Data-Backlog board.

I don't see this error in the logs any more. Possibly someone somehow fixed it, or it might have morphed into T301947. Either way I don't think this task is useful any more.

TypeError: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given, called in /srv/mediawiki/php-1.38.0-wmf.3/includes/EditPage.php on line 646Closed, ResolvedPublicPRODUCTION ERRORActions