IP Info icon should be present on collapsed lines on RecentChanges [M]
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Prtksxna
	Oct 14 2021, 8:56 AM

Description

Special:RecentChanges groups multiple edits in quick succession to the same page and displays them as a single collapsed line item with the user's name still visible.

Collapsed	Expanded

(follow up on T263636)

AC

The IP Info (i) button should be present on the collapsed line
The IP Info (i) button should be present on all lines when the collapsed line is expanded

Details

	Subject	Repo	Branch	Lines +/-
	IP Info icon should be present on collapsed lines on RecentChanges	mediawiki/extensions/IPInfo	master	+13 -2

Customize query in gerrit

Related Objects

Mentioned In: T263636: Make IPInfo tool available on Special:RecentChanges [M]
Mentioned Here: T263636: Make IPInfo tool available on Special:RecentChanges [M]

Event Timeline

• Prtksxna created this task.Oct 14 2021, 8:56 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2021, 8:56 AM

• Prtksxna removed a project: Design.Oct 14 2021, 8:58 AM

• Prtksxna mentioned this in T263636: Make IPInfo tool available on Special:RecentChanges [M].

phuedx updated the task description. (Show Details)Oct 14 2021, 12:54 PM

• Niharika updated the task description. (Show Details)Oct 15 2021, 6:39 PM

• Niharika triaged this task as Medium priority.Oct 19 2021, 5:07 PM

ARamirez_WMF renamed this task from IP Info icon should be present on collapsed lines on RecentChanges to IP Info icon should be present on collapsed lines on RecentChanges [M].Oct 20 2021, 4:27 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Nov 9 2021, 4:28 PM

• Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

• TThoabala claimed this task.Nov 15 2021, 2:42 PM

• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 738968 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] IP Info icon should be present on collapsed lines on RecentChanges

https://gerrit.wikimedia.org/r/738968

gerritbot added a project: Patch-For-Review.Nov 15 2021, 5:02 PM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Nov 15 2021, 5:29 PM

• TThoabala moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Dec 1 2021, 4:54 PM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Dec 6 2021, 10:53 PM

QA steps

Add 2 or more edits anonymously so that the collapse gets created as shown in a screenshot below
Go to Special:RecentChanges

Check that the IP Info (i) button is present on the collapsed line
Check that the IP Info (i) button is present on all lines when the collapsed line is expanded
Check that clicking on the IP Info (i) button works and leads to the correct data both on collapsed and expanded line.

See screenshot below for reference.

Change 738968 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] IP Info icon should be present on collapsed lines on RecentChanges

https://gerrit.wikimedia.org/r/738968

• wikitrent moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Dec 15 2021, 1:21 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 15 2021, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 15 2021, 2:10 PM

• Prtksxna awarded a token.Dec 16 2021, 7:21 AM

Thanks @TThoabala for the QA notes
I was able to test the feature on my local box, since the feature is not on production at this time.

Screen Shot 2021-12-20 at 9.11.03 PM.png (1×2 px, 552 KB)

Screen Shot 2021-12-20 at 9.13.01 PM.png (1×2 px, 626 KB)

• imaigwilo moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment (The Letter Song) board.Dec 21 2021, 4:11 AM

• Niharika closed this task as Resolved.Feb 17 2022, 1:48 AM

• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM

	F34891256: Screen Shot 2021-12-20 at 9.11.03 PM.png
	Dec 21 2021, 3:38 AM

	F34891261: Screen Shot 2021-12-20 at 9.13.01 PM.png
	Dec 21 2021, 3:38 AM

	F34883502: iconQA.png
	Dec 14 2021, 11:29 AM

IP Info icon should be present on collapsed lines on RecentChanges [M]Closed, ResolvedPublicActions

Description

AC

Details

Related Objects

Event Timeline

IP Info icon should be present on collapsed lines on RecentChanges [M]
Closed, ResolvedPublic
Actions