Maniphest T293334

Finesse: tests for the mapdata repo
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

None

Authored By

	awight
	Oct 14 2021, 9:03 AM

Tags

Referenced Files

None

Subscribers

Description

This critical API wrapper has no tests. Write a test suite for title and revid use cases.

Repo: https://gerrit.wikimedia.org/r/admin/repos/mapdata

Integrate a unit testing framework: jest
Add unit tests to cover legacy title logic
Add unit test for revid logic
Enable tests in CI

Details

	Subject	Repo	Branch	Lines +/-
	Test for revid logic	mapdata	wmde-maps-revid	+23 -0
	Newly added mapdata tests don't require a browser	integration/config	master	+1 -1
	Add basic unit tests	mapdata	master	+56 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T293905 Performance review of proposed Kartographer/Kartotherian revid support
		Resolved		thiemowmde	T294339 Deploy versioned maps to the beta cluster
		Resolved		awight	T293844 Merge revid branches to production
		Resolved		None	T293334 Finesse: tests for the mapdata repo

Event Timeline

awight created this task.Oct 14 2021, 9:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2021, 9:03 AM

awight triaged this task as Low priority.Oct 14 2021, 9:05 AM

awight lowered the priority of this task from Low to Lowest.

awight updated the task description. (Show Details)

awight removed a subscriber: Aklapper.

awight moved this task from Backlog to Ready for story time on the WMDE-GeoInfo-FocusArea board.Oct 19 2021, 11:02 PM

awight added a parent task: T293844: Merge revid branches to production.Oct 20 2021, 2:39 PM

awight moved this task from Ready for story time to Ready for pickup on the WMDE-GeoInfo-FocusArea board.

awight mentioned this in T293844: Merge revid branches to production.Nov 1 2021, 9:46 AM

awight added a project: WMDE-TechWish-Sprint-2021-10-27.Nov 1 2021, 9:50 AM

awight updated the task description. (Show Details)

awight updated the task description. (Show Details)Nov 1 2021, 9:55 AM

awight moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2021-10-27 board.

Change 735375 had a related patch set uploaded (by Awight; author: Awight):

[mapdata@master] Add basic unit tests

https://gerrit.wikimedia.org/r/735375

Change 735377 had a related patch set uploaded (by Awight; author: Awight):

[mapdata@wmde-maps-revid] Test for revid logic

https://gerrit.wikimedia.org/r/735377

Change 735939 had a related patch set uploaded (by Awight; author: Awight):

[integration/config@master] Newly added mapdata tests don't require a browser

https://gerrit.wikimedia.org/r/735939

awight set the point value for this task to 2.Nov 1 2021, 10:04 AM

Change 735375 merged by jenkins-bot:

[mapdata@master] Add basic unit tests

https://gerrit.wikimedia.org/r/735375

Change 735939 merged by jenkins-bot:

[integration/config@master] Newly added mapdata tests don't require a browser

https://gerrit.wikimedia.org/r/735939

awight moved this task from Ready for pickup to In sprint on the WMDE-GeoInfo-FocusArea board.Nov 5 2021, 10:34 AM

Change 735377 merged by jenkins-bot:

[mapdata@wmde-maps-revid] Test for revid logic

https://gerrit.wikimedia.org/r/735377

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2021, 3:10 PM

lilients_WMDE moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2021-10-27 board.Nov 9 2021, 1:43 PM

awight closed this task as Resolved.Nov 10 2021, 11:02 AM