| KSiebert | |
| Oct 14 2021, 9:22 AM |
| F35105564: Screen Shot 2022-05-03 at 10.28.13 PM.png | |
| May 6 2022, 3:07 AM |
| F35058998: Screenshot from 2022-04-19 21-31-55.png | |
| Apr 20 2022, 1:36 AM |
| F35059000: Screenshot from 2022-04-19 21-34-40.png | |
| Apr 20 2022, 1:36 AM |
| F34738257: RTpreview-legacy-vertical-toggled.png | |
| Nov 8 2021, 7:18 PM |
| F34689813: Screenshot 2021-10-15 at 12.58.28.png | |
| Oct 15 2021, 11:07 AM |
| F34689816: Screenshot 2021-10-15 at 13.04.31.png | |
| Oct 15 2021, 11:07 AM |
| F34689819: Screenshot 2021-10-15 at 13.06.32.png | |
| Oct 15 2021, 11:07 AM |
| F34688250: Screenshot 2021-10-14 at 11.06.15.png | |
| Oct 14 2021, 9:22 AM |
When I edit on a screen smaller than 600px, I no longer see an option in the toolbar allowing me to preview, in order to prevent a poor user experience
600px
Yes
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Realtime preview: disable preview when screen is small | mediawiki/extensions/WikiEditor | master | +69 -13 |
I'm not sure if a specific ticket will be cut for this but regarding the animation we discussed @NRodriguez, here's an example of how it could look like (without any fancy animations) in a similar way to codesandbox.io when you click on the "toggle preview button" (browser with a play icon).
@NRodriguez @nayoub should the preview mode disappear if user resizes the screen to a width less than 600px?
@HMonroy yes it should disappear. Let me know if there's anything else I can do to unblock you!
Change 784342 had a related patch set uploaded (by HMonroy; author: HMonroy):
[mediawiki/extensions/WikiEditor@master] Realtime preview: disable preview when screen is small
@NRodriguez @nayoub This should probably go by the width of the editing area, not the whole screen, right? Different skins will add content to either side of the editing area which could then make the editing area very narrow (see the Timeless skin for example), thus going by screen width could be misleading. That said, is 600px still what we want? That seems about right but just asking because in old Vector, 600px screen with is a bit narrow for Realtime Preview:
Here's 600px for the editing area (the .wikiEditor-ui element, specifically):
This should probably go by the width of the editing area, not the whole screen, right?
@MusikAnimal correct, the editing area not the whole screen!
@nayoub tested on the editing element being 600px based on editing area so 600px is correct!
@NRodriguez In new Vector, the editing area is ~537px width (on my screen anyway). Does this mean RTP won't be enabled on new Vector? See also T307042.
Oh wait, I was looking at the height, not the width. Ignore this. Nothing to see here.
Change 784342 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Realtime preview: disable preview when screen is small
