Page MenuHomePhabricator

Add Checkbox component to Codex
Closed, ResolvedPublic

Description

See T281186 for previous review of different implementations.

Wikimedia Design Style Guide links:

I would recommend we stick with the WVUI approach for Radio and Checkbox for a few reasons:

  • They require the use of v-model on the end-user side, a standard Vue pattern I would like to encourage for many form elements
  • They use a compasable that wraps v-model values so they can be reused on an input that's not at the root of the template
  • They wrap the input in a label, which gives us a11y features for free

Event Timeline

Change 739881 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] Checkbox, Radio: Add Checkbox, update Radio docs

https://gerrit.wikimedia.org/r/739881

Change 739881 merged by jenkins-bot:

[design/codex@main] Checkbox, Radio: Add Checkbox, update Radio docs

https://gerrit.wikimedia.org/r/739881

Hey @AnneT , is it OK to close/resolve this one?

Volker_E subscribed.

Thanks for the catch @ldelench_wmf. I think that got stalled on subtask T304911 that I've filed and Checkbox, Radio both got resolved successfully in initial release v0.1.0-alpha.1 at 2022-02-14. See also T293270: Add Radio component to Codex.

@ldelench_wmf while this and Radio got released a while ago, they never went through formal QA. We may want to evaluate whether we want to have Ezekiel review those two components before we do a wider release.