Maniphest T293392

Content styles not applied to mobile visual diff
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Oct 14 2021, 4:22 PM

Tags

Referenced Files

	F34689005: image.png
	Oct 14 2021, 6:59 PM

	F34689003: image.png
	Oct 14 2021, 6:59 PM

	F34688823: image.png
	Oct 14 2021, 4:22 PM

	F34688826: image.png
	Oct 14 2021, 4:22 PM

Subscribers

Description

e.g. line-height and padding rules are missing:

image.png (286×342 px, 27 KB)

Expected

image.png (280×346 px, 20 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Add mobile 'content' class to visual diff	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T244673: VisualDiff feature on mobile has an inconsistent style/layout
T292491: Context of Visual differences become invisible under mobile view
Mentioned Here: T244673: VisualDiff feature on mobile has an inconsistent style/layout

Event Timeline

Esanders created this task.Oct 14 2021, 4:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2021, 4:22 PM

Esanders claimed this task.Oct 14 2021, 4:23 PM

Esanders moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.

Esanders mentioned this in T292491: Context of Visual differences become invisible under mobile view.

Esanders moved this task from To Triage to Triaged on the VisualEditor board.

Change 730847 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Add mobile 'content' class to visual diff

https://gerrit.wikimedia.org/r/730847

gerritbot added a project: Patch-For-Review.Oct 14 2021, 4:26 PM

Esanders moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Oct 14 2021, 4:27 PM

More screenshots – notably, this fixes the display of list items (which I complained about a while ago in T244673#6110852).

Before	After

Change 730847 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add mobile 'content' class to visual diff

https://gerrit.wikimedia.org/r/730847

matmarex edited projects, added Editing QA; removed Patch-For-Review.Oct 14 2021, 7:26 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

matmarex mentioned this in T244673: VisualDiff feature on mobile has an inconsistent style/layout.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 14 2021, 8:00 PM

Ryasmeen edited projects, added Verified; removed Editing QA.Oct 14 2021, 9:26 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

• ppelberg closed this task as Resolved.Oct 16 2021, 12:39 AM