Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
137 errors in last 12hrs https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.10.14?id=4Rojf3wB1RMACsoSBE6q
In older browsers you can't use forEach on a NodeList

What should have happened instead?:
We should use Array.prototype.forEach.call inside resources/skins.vector.js/searchLoader.js

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/Vector	master	+3 -2	Avoid calling forEach on searchbox NodeList for older browsers

Mentioned In: T298911: Consider checking for NodeList.prototype.forEach as part of Grade A support or providing a polyfill

Jdlrobson triaged this task as High priority.Oct 14 2021, 6:31 PM

ovasileva set the point value for this task to 2.Oct 18 2021, 5:48 PM

bwang removed bwang as the assignee of this task.Oct 18 2021, 5:55 PM

bwang added a subscriber: bwang.

Change 731788 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Avoid calling forEach on searchbox NodeList for older browsers

Change 731788 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Avoid calling forEach on searchbox NodeList for older browsers

I'll verify this one in logstash when its deployed (Wednesday)

After the train this seems to be trailing off

	F34704956: Screen Shot 2021-10-21 at 10.31.50 AM.png
	Oct 21 2021, 5:32 PM