Page MenuHomePhabricator

ParserOutput::getText() should be removed from ParserOutput
Closed, ResolvedPublic

Description

There is a bunch of 'parse rendering' code in ParserOutput::getText() which has no place in (what we hope will be) a plain value object.

Further, getText() operates directly on the HTML as a string; in the Parsoid world it should be operating (and returning) a DOM tree instead.

Related methods: ParserOutput::addWrapperDivClass(), ::clearWrapperDivClass().

Perhaps the "postprocessing" step here belongs somewhere in the Content hierarchy?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/extensions/MathREL1_44+1 -1
mediawiki/extensions/MathREL1_43+4 -4
mediawiki/coremaster+0 -57
mediawiki/extensions/DiscussionToolsREL1_44+4 -3
mediawiki/extensions/DiscussionToolsmaster+4 -3
mediawiki/extensions/EchoREL1_44+4 -3
mediawiki/coreREL1_44+14 -217
mediawiki/extensions/ParserMigrationREL1_44+5 -4
mediawiki/extensions/ParserMigrationmaster+5 -4
mediawiki/extensions/MediaUploadermaster+3 -3
mediawiki/coremaster+14 -217
mediawiki/coremaster+5 -0
mediawiki/extensions/Mathmaster+1 -1
mediawiki/extensions/Echomaster+4 -3
mediawiki/extensions/CentralNoticewmf_deploy+0 -0
mediawiki/coremaster+6 -4
mediawiki/extensions/LiquidThreadsmaster+11 -1
mediawiki/extensions/CentralNoticemaster+7 -4
mediawiki/extensions/PageTriagemaster+2 -4
mediawiki/extensions/SecurePollmaster+3 -3
mediawiki/extensions/UploadWizardmaster+3 -3
mediawiki/extensions/Wikibasemaster+32 -27
mediawiki/extensions/FileImportermaster+2 -2
mediawiki/extensions/Mathmaster+4 -4
mediawiki/extensions/Newslettermaster+1 -1
mediawiki/extensions/RSSmaster+1 -1
mediawiki/extensions/CiteThisPagemaster+1 -6
mediawiki/extensions/MassMessagemaster+2 -1
mediawiki/extensions/TemplateSandboxmaster+2 -2
mediawiki/extensions/TemplateStylesmaster+1 -1
mediawiki/extensions/GeoDatamaster+1 -1
mediawiki/extensions/Wikistoriesmaster+1 -1
mediawiki/coremaster+2 -0
mediawiki/extensions/EventLoggingmaster+1 -1
mediawiki/extensions/EntitySchemamaster+7 -7
mediawiki/extensions/FeaturedFeedsmaster+2 -2
mediawiki/coremaster+16 -5
mediawiki/coremaster+55 -33
mediawiki/extensions/CheckUsermaster+2 -1
mediawiki/extensions/AbuseFiltermaster+4 -2
mediawiki/extensions/Citemaster+1 -1
mediawiki/extensions/ProofreadPagemaster+6 -2
mediawiki/extensions/CommonsMetadatamaster+3 -2
mediawiki/coremaster+34 -24
mediawiki/coremaster+32 -21
mediawiki/coremaster+431 -280
mediawiki/coremaster+59 -70
mediawiki/coremaster+77 -17
mediawiki/coremaster+8 -0
mediawiki/coremaster+114 -68
mediawiki/coremaster+97 -90
mediawiki/coremaster+521 -3
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
Resolvedihurbain
Opencscott
Openihurbain
Resolvedihurbain
Resolvedcscott
Resolvedihurbain
Resolvedcscott
Resolvedihurbain
OpenNone
Opencscott
OpenBUG REPORTNone
Openihurbain
Openihurbain
Openihurbain
Openihurbain
Openihurbain
OpenNone
Resolvedihurbain
OpenNone
OpenNone
OpenNone
Openihurbain
OpenNone
OpenNone
Resolvedssastry
OpenNone
OpenNone
Resolvedssastry
Resolvedihurbain
OpenNone
OpenNone
Resolvedihurbain

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change #1093952 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/CentralNotice@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1093952

Change #1093969 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/CheckUser@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1093969

Change #1093971 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Cite@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1093971

Change #1093859 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1093859

Change #1093971 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1093971

Change #1093969 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1093969

Change #1093908 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1093908

Change #1094414 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Add a comment to avoid premature hard deprecation of getText

https://gerrit.wikimedia.org/r/1094414

Change #1094478 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/CiteThisPage@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1094478

Change #1094502 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Add $linestart to parseWithPostProcessing

https://gerrit.wikimedia.org/r/1094502

Change #1094502 merged by jenkins-bot:

[mediawiki/core@master] Add $linestart to parseWithPostprocessing

https://gerrit.wikimedia.org/r/1094502

Change #1097407 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Echo@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1097407

Change #1097427 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/EntitySchema@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1097427

Change #1098047 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/EventLogging@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1098047

Change #1098052 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FeaturedFeeds@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1098052

Change #1097427 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1097427

Change #1098052 merged by jenkins-bot:

[mediawiki/extensions/FeaturedFeeds@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1098052

Change #1098047 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1098047

Change #1098983 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FileImporter@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1098983

Change #1099300 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/GeoData@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099300

Change #1099352 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/MassMessage@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099352

Change #1099356 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Math@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099356

Change #1099357 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Newsletter@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099357

Change #1099363 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/RSS@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099363

Change #1099370 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/SecurePoll@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099370

Change #1099373 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/TemplateSandbox@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099373

Change #1099374 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/TemplateStyles@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099374

Change #1099375 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/UploadWizard@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099375

Change #1099376 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Wikistories@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099376

Change #1094414 merged by jenkins-bot:

[mediawiki/core@master] Add a comment to avoid premature hard deprecation of getText

https://gerrit.wikimedia.org/r/1094414

Change #1099376 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099376

Change #1099745 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/LiquidThreads@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099745

Change #1099747 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/PageTriage@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099747

Change #1100169 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Wikibase@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1100169

Change #1099300 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099300

Change #1099374 merged by jenkins-bot:

[mediawiki/extensions/TemplateStyles@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099374

Change #1099373 merged by jenkins-bot:

[mediawiki/extensions/TemplateSandbox@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099373

Change #1099352 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099352

Change #1094478 merged by jenkins-bot:

[mediawiki/extensions/CiteThisPage@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1094478

Change #1099363 merged by jenkins-bot:

[mediawiki/extensions/RSS@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099363

Change #1099357 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099357

Change #1099356 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099356

Change #1098983 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1098983

Change #1100169 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1100169

Change #1099375 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099375

Change #1109468 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Tweak MessageCache::parseWithPostprocessing for Echo compatibility

https://gerrit.wikimedia.org/r/1109468

Change #1099370 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099370

Change #1099747 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099747

Change #1099745 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1099745

Change #1093952 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1093952

Change #1109468 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/core@master] Tweak MessageCache::parseWithPostprocessing for Echo compatibility

Reason:

don't need that after all

https://gerrit.wikimedia.org/r/1109468

Change #1116813 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge remote-tracking branch 'origin/master' into wmf_deploy for the first time since August

https://gerrit.wikimedia.org/r/1116813

Change #1116813 abandoned by Jforrester:

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge remote-tracking branch 'origin/master' into wmf_deploy for the first time since August

Reason:

Done in I2780f41fb3ab98a61f89fc27977686f3e659e6d1 instead.

https://gerrit.wikimedia.org/r/1116813

Change #1130288 had a related patch set uploaded (by Krinkle; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Math@REL1_43] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1130288

Change #1097407 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1097407

Change #1146498 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Add a deprecation notice for ParserOutput::getText

https://gerrit.wikimedia.org/r/1146498

Change #1146557 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] [DNM] Hard-deprecate ParserOutput::getText

https://gerrit.wikimedia.org/r/1146557

Change #1147032 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Math@master] Remove stray getText in tests

https://gerrit.wikimedia.org/r/1147032

Change #1147032 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Remove stray getText in tests

https://gerrit.wikimedia.org/r/1147032

Change #1146498 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/core@master] Add a deprecation notice for ParserOutput::getText

Reason:

folded into I733fa94d8ea7c9aa93a117df6d2c72df942f02ca

https://gerrit.wikimedia.org/r/1146498

Change #1146557 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate ParserOutput::getText

https://gerrit.wikimedia.org/r/1146557

Change #1152107 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MediaUploader@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1152107

Change #1153969 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/ParserMigration@master] Remove deprecated usages of ParserOutput::getText

https://gerrit.wikimedia.org/r/1153969

Change #1153994 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@REL1_44] Hard-deprecate ParserOutput::getText

https://gerrit.wikimedia.org/r/1153994

Change #1152107 merged by Jforrester:

[mediawiki/extensions/MediaUploader@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1152107

Change #1153969 merged by jenkins-bot:

[mediawiki/extensions/ParserMigration@master] Remove deprecated usages of ParserOutput::getText

https://gerrit.wikimedia.org/r/1153969

Change #1154063 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/ParserMigration@REL1_44] Remove deprecated usages of ParserOutput::getText

https://gerrit.wikimedia.org/r/1154063

Change #1154063 merged by jenkins-bot:

[mediawiki/extensions/ParserMigration@REL1_44] Remove deprecated usages of ParserOutput::getText

https://gerrit.wikimedia.org/r/1154063

Change #1153994 merged by jenkins-bot:

[mediawiki/core@REL1_44] Hard-deprecate ParserOutput::getText

https://gerrit.wikimedia.org/r/1153994

Change #1155307 had a related patch set uploaded (by Arlolra; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Echo@REL1_44] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1155307

Change #1155307 merged by jenkins-bot:

[mediawiki/extensions/Echo@REL1_44] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1155307

Change #1161595 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Replace use of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1161595

Change #1161595 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Replace use of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1161595

Change #1162009 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@REL1_44] Replace use of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1162009

Change #1162009 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_44] Replace use of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1162009

Change #1166755 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Remove ParserOutput::getText method

https://gerrit.wikimedia.org/r/1166755

Change #1166755 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::getText method

https://gerrit.wikimedia.org/r/1166755

Change #1130288 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_43] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1130288

Change #1203236 had a related patch set uploaded (by Umherirrender; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Math@REL1_44] Remove stray getText in tests

https://gerrit.wikimedia.org/r/1203236

Change #1203236 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_44] Remove stray getText in tests

https://gerrit.wikimedia.org/r/1203236