Page MenuHomePhabricator

Migrate ParserOutput::addWarning() to ::addWarningMsg()
Closed, ResolvedPublic

Description

Almost every call to ParserOutput::addWarning() looks like this:

					$this->parser->getOutput()->addWarning( wfMessage( 'duplicate-args-warning',
							wfEscapeWikiText( $this->title ),
							wfEscapeWikiText( $title ),
							wfEscapeWikiText( $index ) )->text() );

Code search: https://codesearch.wmcloud.org/deployed/?q=%5BOo%5Dutput(%5C(%5C))%3F-%3EaddWarning&i=nope&files=&excludeFiles=&repos=

Instead of pushing the localization into Parsoid, the ParserOutput interface should accept a message key and arguments, and handle the wfMesssage( $key, ...$args )->text() portion itself. This would also be consistent with (eg) addTrackingCategory() which also takes a message key (not a localized category name).

Proposed new method:

public function addWarningMsg( string $key, ...$args );

(This also encourages extension authors to properly localize their warnings!)

Related Objects

StatusSubtypeAssignedTask
OpenReleaseNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenFeatureNone
OpenNone
OpenNone
OpenNone
Resolveddaniel
Resolvedcscott
OpenNone
OpenNone
Resolvedcscott
Resolvedssastry
StalledNone
Resolvedssastry
OpenNone
Resolvedcscott
OpenNone
Resolvedcscott

Event Timeline

Change 731169 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Deprecate ParserOutput::addWarning() in favor of ::addWarningMsg()

https://gerrit.wikimedia.org/r/731169

Change 731172 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/WikidataPageBanner@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731172

Change 731170 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Hard deprecate ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731170

Change 731175 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Scribunto@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731175

Change 731176 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/BlueSpiceBookshelf@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731176

Change 731177 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/PageInCat@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731177

Change 731178 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/TEI@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731178

Change 731169 merged by jenkins-bot:

[mediawiki/core@master] Deprecate ParserOutput::addWarning() in favor of ::addWarningMsg()

https://gerrit.wikimedia.org/r/731169

Change 731172 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731172

Change 731175 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731175

Change 731177 merged by jenkins-bot:

[mediawiki/extensions/PageInCat@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731177

Change 731170 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731170

Change 731178 merged by jenkins-bot:

[mediawiki/extensions/TEI@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731178

Change 731176 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceBookshelf@master] Replace use of deprecated ParserOutput::addWarning()

https://gerrit.wikimedia.org/r/731176

cscott claimed this task.

Change 871249 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/NoCat@master] Avoid deprecated ParserOutput::addWarning

https://gerrit.wikimedia.org/r/871249

Change 871249 merged by jenkins-bot:

[mediawiki/extensions/NoCat@master] Avoid deprecated ParserOutput::addWarning

https://gerrit.wikimedia.org/r/871249