Page MenuHomePhabricator
Create Task
Maniphest T293554

Switching tabs in MediaSearch does not re-query the search
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • You get "We didn't find any results Try more general terms or check your spelling"
  • No API calls are being made when switching the tab

What should have happened instead?:
Upon clicking a new tab, MediaSearch should query the search and display the result.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Firefox 93 in private browsing mode (aka logged out), Wikimedia Commons

Search results in a different tab appear only after reloading the page, or when changing a filter/sort. The bug only happens when you search from the search bar from outside of Special:MediaSearch, repeating the query inside Special:MediaSearch does not produce this bug.

Details

SubjectRepoBranchLines +/-
Refactor the URI.querymediawiki/extensions/MediaSearchwmf/1.38.0-wmf.5+684 -187
Refactor the URI.querymediawiki/extensions/MediaSearchwmf/1.38.0-wmf.4+684 -187
Refactor the URI.querymediawiki/extensions/MediaSearchmaster+684 -187
Revert 727328mediawiki/extensions/MediaSearchwmf/1.38.0-wmf.4+5 -5
Revert 727328mediawiki/extensions/MediaSearchmaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

Trougnouf created this task.Oct 16 2021, 2:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2021, 2:59 PM
Trougnouf updated the task description. (Show Details)Oct 16 2021, 3:02 PM
Trougnouf added a comment.Oct 16 2021, 3:04 PM

Actually going on the reported url https://commons.wikimedia.org/w/index.php?search=Domaine+Solvay&title=Special:MediaSearch&go=Go&type=page manually returns results.

Clicking on "Categories and Pages" (which yields that url) returns an empty list with the message "We didn't find any results Try more general terms or check your spelling"

Dylsss renamed this task from Search by category is broken, requires many steps and howto to Switching tabs in MediaSearch does not re-query the search.Oct 17 2021, 11:23 AM
Dylsss edited projects, added SDAW-MediaSearch; removed Advanced-Search.
Dylsss updated the task description. (Show Details)
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptOct 17 2021, 11:24 AM
Dylsss subscribed.Oct 17 2021, 11:25 AM

I've updated the task description to better describe the bug, which is not specifically to do with categories and more to do with the fact that switching to any different tab does not re-query the search in that tab. Hope that is ok.

Trougnouf added a comment.Oct 17 2021, 11:27 AM
In T293554#7434361, @Dylsss wrote:

I've updated the task description to better describe the bug, which is not specifically to do with categories and more to do with the fact that switching to any different tab does not re-query the search in that tab. Hope that is ok.

Yes, thank you @Dylsss

Dylsss updated the task description. (Show Details)Oct 17 2021, 11:27 AM
Dylsss removed a project: MediaWiki-Categories.Oct 17 2021, 11:30 AM
Dylsss updated the task description. (Show Details)Oct 17 2021, 11:35 AM
SimoneThisDot subscribed.Oct 18 2021, 3:31 PM

The issue seem to be correlated to the following change https://phabricator.wikimedia.org/T291622, that is preventing the system to sent new API request.

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 18 2021, 3:52 PM
CBogen moved this task from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.
CBogen assigned this task to Seddon.Oct 18 2021, 3:54 PM
gerritbot added a comment.Oct 18 2021, 6:31 PM

Change 731785 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/MediaSearch@master] Revert 727328

https://gerrit.wikimedia.org/r/731785

gerritbot added a project: Patch-For-Review.Oct 18 2021, 6:31 PM
gerritbot added a comment.Oct 18 2021, 6:54 PM

Change 731808 had a related patch set uploaded (by Urbanecm; author: Seddon):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Revert 727328

https://gerrit.wikimedia.org/r/731808

gerritbot added a comment.Oct 18 2021, 7:14 PM

Change 731785 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Revert 727328

https://gerrit.wikimedia.org/r/731785

gerritbot added a comment.Oct 18 2021, 7:22 PM

Change 731808 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Revert 727328

https://gerrit.wikimedia.org/r/731808

Stashbot added a comment.Oct 18 2021, 7:29 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T19:29:34Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/MediaSearch/resources/store/state.js: ac7b4fc2ccc69589e00a42f49d18a8f6d71777f2: Revert 727328 (T293554) (duration: 00m 56s)

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 18 2021, 8:00 PM
CBogen moved this task from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 18 2021, 8:09 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 18 2021, 8:10 PM
gerritbot added a comment.Oct 19 2021, 1:29 AM

Change 730208 had a related patch set uploaded (by Seddon; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

gerritbot added a project: Patch-For-Review.Oct 19 2021, 1:29 AM
gerritbot added a comment.Oct 19 2021, 10:43 AM

Change 730208 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

gerritbot added a comment.Oct 19 2021, 6:08 PM

Change 731961 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

gerritbot added a comment.Oct 19 2021, 6:08 PM

Change 731962 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

gerritbot added a comment.Oct 19 2021, 6:34 PM

Change 731961 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

gerritbot added a comment.Oct 19 2021, 6:34 PM

Change 731962 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

Stashbot mentioned this in T293335: Cannot convert undefined or null to object when trying to restorePageState.Oct 19 2021, 6:45 PM
Stashbot mentioned this in T291622: [M] CheckForMore always return true.

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:45:27Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/MediaSearch/: 694580a: c02e301: MediaSearch backports(T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Stashbot mentioned this in T291392: Refactor the URI.query.Oct 19 2021, 6:45 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:46:30Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/MediaSearch/: a84a675: 3231578: MediaSearch backports (T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Etonkovidova closed this task as Resolved.Oct 20 2021, 1:17 AM
Etonkovidova subscribed.

Checked after deployment to commons wmf.4 - the fix seems to be in place.

Trougnouf added a comment.Oct 24 2021, 10:55 PM

Thank you for the fast and effective fix!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL