Show disambiguation extract in preview instead of custom disambiguation view
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hueitan
	Oct 18 2021, 7:28 AM

Description

In many cases, summary api returns the disambiguation page extract description, somehow it can be useful instead of just redirect link.

We can't promise it always has the extract information, therefore the existing redirect link/text will be provided when extract is not available.

Storybook to try: https://wikimedia.github.io/wikipedia-preview/main/storybook/?path=/story/targets--hyperlink&args=title:seo

with extract info	when no extract info

Here's the link for more disambiguation pages
https://en.wikipedia.org/wiki/Wikipedia:Links_to_disambiguating_pages

QA Results - Storybook

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T293594 here

Related Objects

Mentioned In: T294631: disambiguation page preview is not looking great after publishing
T284598: Gutenburg custom format - search
Mentioned Here: T356846: Remove Disambiguation type search results while adding a Wikipedia Preview

Event Timeline

hueitan created this task.Oct 18 2021, 7:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2021, 7:28 AM

hueitan mentioned this in T284598: Gutenburg custom format - search.Oct 18 2021, 1:33 PM

SBisson mentioned this in T294631: disambiguation page preview is not looking great after publishing.Nov 22 2021, 6:57 PM

SBisson merged a task: T294631: disambiguation page preview is not looking great after publishing.Jun 18 2022, 1:08 AM

SBisson added subscribers: • Jpita, SBisson, SGautam_WMF, • AMuigai.

SBisson moved this task from Kanban to Backlog on the Inuka-Team board.May 10 2023, 12:54 PM

SBisson edited projects, added Inuka-Team; removed Inuka-Team (Kanban).

SBisson moved this task from Backlog to Next on the Inuka-Team board.Jun 13 2023, 7:55 PM

SBisson edited projects, added Inuka-Team (Next); removed Inuka-Team.

• PWaigi-WMF triaged this task as Medium priority.Feb 7 2024, 4:14 PM

• PWaigi-WMF edited projects, added Inuka-Team (Kanban); removed Inuka-Team (Next).

• PWaigi-WMF moved this task from Backlog to Definition on the Inuka-Team (Kanban) board.

• PWaigi-WMF moved this task from Definition to Ready for Dev on the Inuka-Team (Kanban) board.

SBisson renamed this task from [Suggestion] Show disambiguation extract in preview instead of redirect disambiguation suggested text when available to Show disambiguation extract in preview instead of custom disambiguation view.Feb 20 2024, 1:36 PM

PR: https://github.com/wikimedia/wikipedia-preview/pull/185

If anyone can find a disambiguation page with no extract data, please post it here and I will update the test spec in the code.

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Feb 21 2024, 1:56 PM

hueitan updated the task description. (Show Details)Mar 5 2024, 3:33 PM

@hueitan Here are a few summary Api returns disambiguation page extract descriptions besides a redirect link as seen in the screenshots below. I will move this to design sign-off. Thanks for all your work and for updating the task!

Status: ✅PASS
Environment: WordPress 6.4.3; Wikipedia Preview 1.12
OS: macOS Sonoma 14.2.1
Browser: Chrome 122
Skins. N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://wikimedia.github.io/wikipedia-preview/main/storybook/?path=/story/targets--hyperlink&args=title:seo
https://en.wikipedia.org/wiki/Seo
https://wikimedia.github.io/wikipedia-preview/main/storybook/?path=/story/targets--hyperlink&args=title:net
https://en.wikipedia.org/wiki/Net
https://wikimedia.github.io/wikipedia-preview/main/storybook/?path=/story/targets--hyperlink&args=title:zip
https://en.wikipedia.org/wiki/Zip

✅AC1: https://phabricator.wikimedia.org/T293594

Disambiguate Word	Storybook	Wikipedia
SEO
Net
Zip

GMikesell-WMF updated the task description. (Show Details)Mar 5 2024, 5:08 PM

GMikesell-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Mar 12 2024, 4:12 AM

@hueitan change in this task looks fine to me though I also think once we deploy changes mentioned in T356846 then changes as part of this task won't be of any use?

In T293594#9622398, @SGautam_WMF wrote:

@hueitan change in this task looks fine to me though I also think once we deploy changes mentioned in T356846 then changes as part of this task won't be of any use?

Yes, WPP won't show disambiguation page anymore.

It's still available for those who don't use wordpress plugin but the WP library itself.

• PWaigi-WMF closed this task as Resolved.Mar 13 2024, 1:18 PM

	F42398580: Screenshot 2024-03-05 at 23.30.49.png
	Mar 5 2024, 3:33 PM

Show disambiguation extract in preview instead of custom disambiguation viewClosed, ResolvedPublicActions

Description

QA Results - Storybook

Related Objects

Event Timeline

Show disambiguation extract in preview instead of custom disambiguation view
Closed, ResolvedPublic
Actions