Page MenuHomePhabricator

Remove getPageActionsHtml and related methods
Closed, ResolvedPublic3 Estimated Story Points

Description

MinervaTemplate::getTemplateData sets a template data key pageactionshtml. This should be migrated to SkinMinerva::getTemplateData
When making this change we want to remove the use of TemplateParser inside SkinMinerva. Instead {{>PageActions}} will be used directly in the template.

TODO

  • MinervaTemplate::getPageActionsHtml should be removed, in its place SkinMinerva::getPageActionsData will be created.

QA steps

For AMC, anonymous users and non-AMC confirm:

  1. there are no UI regressions at the top of the page (where the edit icon/language icon is)
  2. the talk tabs are present at the top of the page (AMC only)

on the following pages:

Developer notes

  • You'll likely need to set a private variable in SkinMinerva::prepareMenus to make this work
  • The components folder is likely to cause some problems given the non-standard way it loads partials.

QA Results - Beta

ACStatusDetails
1skipping beta testing per T293813#7493197
2skipping beta testing per T293813#7493197
3skipping beta testing per T293813#7493197
4skipping beta testing per T293813#7493197

QA Results - Prod

Event Timeline

Jdlrobson lowered the priority of this task from High to Medium.Oct 19 2021, 5:34 PM

Change 732030 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove getPageActionsHtml and related methods

https://gerrit.wikimedia.org/r/732030

Change 732032 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Inline PageActionsMenu template

https://gerrit.wikimedia.org/r/732032

bwang removed bwang as the assignee of this task.Oct 21 2021, 3:16 PM
bwang claimed this task.
bwang added a subscriber: bwang.

Change 732030 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove getPageActionsHtml and related methods

https://gerrit.wikimedia.org/r/732030

Change 732032 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Inline PageActionsMenu template

https://gerrit.wikimedia.org/r/732032

Edtadros added a subscriber: Edtadros.

@bwang Can you add some test steps to this please?

Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

@Edtadros this is in production now, and I think if there was any UI regressions we would have heard about them by now.

I've added some QA steps for in production. I've checked them all and they look fine, but not sure if you want to record some screenshots for completness.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

For AMC, anonymous users and non-AMC confirm:

  1. there are no UI regressions at the top of the page (where the edit icon/language icon is)
  2. the talk tabs are present at the top of the page (AMC only)

on the following pages:

✅ AC1: https://en.m.wikipedia.org/wiki/User:Jdlrobson (NOTE: talk tabs should shown for all users)

AMCAnonnon-AMC
Screen Shot 2021-11-11 at 6.49.52 AM.png (895×414 px, 151 KB)
Screen Shot 2021-11-11 at 6.54.22 AM.png (895×414 px, 148 KB)
Screen Shot 2021-11-11 at 6.58.09 AM.png (895×414 px, 150 KB)

✅ AC2: https://en.m.wikipedia.org/wiki/User_talk:Jdlrobson (NOTE: talk tabs should shown for all users)

AMCAnonnon-AMC
Screen Shot 2021-11-11 at 6.51.15 AM.png (895×414 px, 90 KB)
Screen Shot 2021-11-11 at 6.55.16 AM.png (895×414 px, 87 KB)
Screen Shot 2021-11-11 at 6.58.41 AM.png (895×414 px, 90 KB)

✅ AC3: https://en.m.wikipedia.org/wiki/Agostino_Giustiniani (NOTE: article/talk tab should not show to anonymous users)

AMCAnonnon-AMC
Screen Shot 2021-11-11 at 6.52.12 AM.png (895×414 px, 251 KB)
Screen Shot 2021-11-11 at 6.55.59 AM.png (895×414 px, 241 KB)
Screen Shot 2021-11-11 at 6.59.08 AM.png (895×414 px, 243 KB)

✅ AC4: https://en.m.wikipedia.org/wiki/Talk:Agostino_Giustiniani (NOTE: article/talk tab should not show to anonymous users)

AMCAnonnon-AMC
Screen Shot 2021-11-11 at 6.53.04 AM.png (895×414 px, 64 KB)
Screen Shot 2021-11-11 at 6.56.38 AM.png (895×414 px, 55 KB)
Screen Shot 2021-11-11 at 6.59.32 AM.png (895×414 px, 53 KB)