Page MenuHomePhabricator
Create Task
Maniphest T293834

Opening lede section in mobile VE jumps to the wrong place on specific article
Closed, ResolvedPublic
Actions

Description

  1. Open https://en.m.wikipedia.org/wiki/Alan_Pardew
  2. Edit the lede section
  3. Observe the invisible template "British English" above the infobox is focused, instead of the lede paragraph.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
identifyLeadParagraph: Skip over invisible template paragraphsmediawiki/extensions/MobileFrontendmaster+8 -3
Customize query in gerrit

Event Timeline

Esanders created this task.Oct 19 2021, 10:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2021, 10:00 PM
Esanders updated the task description. (Show Details)Oct 19 2021, 10:22 PM
gerritbot added a comment.Oct 19 2021, 11:13 PM

Change 732101 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] identifyLeadParagraph: Skip over invisible template paragraphs

https://gerrit.wikimedia.org/r/732101

gerritbot added a project: Patch-For-Review.Oct 19 2021, 11:13 PM
ppelberg added a project: Editing-team (Kanban Board).Oct 20 2021, 12:17 AM
ppelberg moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
Esanders moved this task from To Triage to Triaged on the VisualEditor board.Oct 20 2021, 9:19 AM
gerritbot added a comment.Oct 20 2021, 5:16 PM

Change 732101 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] identifyLeadParagraph: Skip over invisible template paragraphs

https://gerrit.wikimedia.org/r/732101

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 20 2021, 5:17 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 20 2021, 6:00 PM
EAkinloose subscribed.Oct 29 2021, 5:08 AM

This works fine now as the paragraph is focused.

Screenshot 2021-10-29 at 06.07.15.png (1×1 px, 294 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Oct 29 2021, 5:08 AM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Nov 6 2021, 12:39 AM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits