Page MenuHomePhabricator
Create Task
Maniphest T293844

Merge revid branches to production
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Many of our changes will be safe to deploy immediately, and will handle legacy maps traffic.

See T293843 for the full migration.

Make sure all patches that go to master have tests added, if possible.

Details

SubjectRepoBranchLines +/-
Relay optional revision ID parametermapdatamaster+38 -6
Pass revid parameter through to mapdatamediawiki/services/kartotherianmaster+49 -7
Support versioned static mapframesmediawiki/extensions/Kartographermaster+70 -2
Support versioned live mapsmediawiki/extensions/Kartographermaster+603 -535
mapdata API support for versioned mapsmediawiki/extensions/Kartographermaster+61 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Oct 19 2021, 11:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2021, 11:01 PM
awight added a subtask: T293843: Plan detailed migration for our revid / mapdata changes.Oct 19 2021, 11:01 PM
awight updated the task description. (Show Details)
awight added a subtask: T293334: Finesse: tests for the mapdata repo.Oct 20 2021, 2:39 PM
awight mentioned this in WMDE-TechWish-Sprint-2021-10-27.Oct 27 2021, 8:20 AM
thiemowmde added a project: WMDE-TechWish-Sprint-2021-10-27.Oct 27 2021, 8:21 AM
thiemowmde updated the task description. (Show Details)Oct 27 2021, 8:48 AM
thiemowmde set the point value for this task to 8.
awight claimed this task.Oct 28 2021, 11:04 AM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-10-27 board.

I'll look into tests for a moment...

gerritbot added a comment.Oct 28 2021, 12:34 PM

Change 735375 had a related patch set uploaded (by Awight; author: Awight):

[mapdata@master] Add basic unit tests

https://gerrit.wikimedia.org/r/735375

gerritbot added a project: Patch-For-Review.Oct 28 2021, 12:34 PM
gerritbot added a comment.Oct 28 2021, 12:39 PM

Change 735377 had a related patch set uploaded (by Awight; author: Awight):

[mapdata@wmde-maps-revid] Test for revid logic

https://gerrit.wikimedia.org/r/735377

awight updated the task description. (Show Details)Oct 28 2021, 12:47 PM
awight updated the task description. (Show Details)Oct 28 2021, 12:54 PM
awight removed awight as the assignee of this task.Oct 28 2021, 2:25 PM
awight moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2021-10-27 board.
awight updated the task description. (Show Details)Nov 1 2021, 9:46 AM
awight updated the task description. (Show Details)Nov 1 2021, 9:50 AM
awight updated the task description. (Show Details)Nov 1 2021, 10:01 AM
awight removed a project: Patch-For-Review.
awight moved this task from Sprint Backlog to Watching (Stalled / Epic) on the WMDE-TechWish-Sprint-2021-10-27 board.
awight updated the task description. (Show Details)Nov 1 2021, 10:04 AM
awight updated the task description. (Show Details)
awight removed the point value for this task.
awight updated the task description. (Show Details)Nov 1 2021, 10:28 AM
awight updated the task description. (Show Details)
awight updated the task description. (Show Details)Nov 1 2021, 10:30 AM
awight updated the task description. (Show Details)Nov 1 2021, 1:57 PM
awight updated the task description. (Show Details)Nov 2 2021, 2:27 PM
awight added a parent task: T294339: Deploy versioned maps to the beta cluster.Nov 4 2021, 2:36 PM
awight moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.Nov 5 2021, 10:33 AM
WMDE-Fisch updated the task description. (Show Details)Nov 5 2021, 6:17 PM
thiemowmde closed subtask T294734: Add phpunit tests to Kartographer that cover revid changes as Resolved.Nov 9 2021, 12:55 PM
awight closed subtask T293334: Finesse: tests for the mapdata repo as Resolved.Nov 10 2021, 11:02 AM
awight added a project: WMDE-TechWish-Sprint-2021-11-10.
awight moved this task from Sprint Backlog to Watching (Stalled / Epic) on the WMDE-TechWish-Sprint-2021-11-10 board.
awight closed subtask T294733: Write varnish_test for maps revid changes as Resolved.Nov 12 2021, 8:50 AM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2021-11-24.Nov 24 2021, 12:19 PM
WMDE-Fisch moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2021-11-24 board.Nov 24 2021, 12:23 PM
WMDE-Fisch moved this task from Watching / Epic / Stalled to Sprint Backlog on the WMDE-TechWish-Sprint-2021-11-24 board.
awight updated the task description. (Show Details)Nov 25 2021, 2:12 PM
awight updated the task description. (Show Details)Nov 25 2021, 2:16 PM
WMDE-Fisch renamed this task from [Epic] Merge "safe" revid changes to production to Merge "safe" revid changes to production.Nov 25 2021, 2:20 PM
WMDE-Fisch set the point value for this task to 3.
awight closed subtask T294735: Write Kartotherian tests for revid pass-through as Resolved.Nov 26 2021, 10:52 AM
awight claimed this task.Nov 29 2021, 2:10 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-11-24 board.
gerritbot added a comment.Nov 29 2021, 2:12 PM

Change 742467 had a related patch set uploaded (by Awight; author: Awight):

[mapdata@master] Relay optional revision ID parameter

https://gerrit.wikimedia.org/r/742467

gerritbot added a project: Patch-For-Review.Nov 29 2021, 2:12 PM
awight updated the task description. (Show Details)Nov 29 2021, 2:16 PM
gerritbot added a comment.Nov 29 2021, 2:23 PM

Change 742472 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/services/kartotherian@master] Pass revid parameter through to mapdata

https://gerrit.wikimedia.org/r/742472

gerritbot added a comment.Nov 29 2021, 3:00 PM

Change 742477 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] [WIP] Support versioned maps

https://gerrit.wikimedia.org/r/742477

awight removed awight as the assignee of this task.Nov 29 2021, 3:03 PM
awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2021-11-24 board.
gerritbot added a comment.Nov 30 2021, 12:40 PM

Change 742711 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] mapdata API support for versioned maps

https://gerrit.wikimedia.org/r/742711

gerritbot added a comment.Nov 30 2021, 12:40 PM

Change 742712 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] Support versioned static mapframes

https://gerrit.wikimedia.org/r/742712

gerritbot added a comment.Dec 3 2021, 11:09 AM

Change 742711 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] mapdata API support for versioned maps

https://gerrit.wikimedia.org/r/742711

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 3 2021, 12:00 PM
awight closed subtask T293843: Plan detailed migration for our revid / mapdata changes as Resolved.Dec 6 2021, 12:11 PM
gerritbot added a comment.Dec 6 2021, 12:52 PM

Change 742467 merged by jenkins-bot:

[mapdata@master] Relay optional revision ID parameter

https://gerrit.wikimedia.org/r/742467

gerritbot added a comment.Dec 7 2021, 3:10 PM

Change 742477 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Support versioned live maps

https://gerrit.wikimedia.org/r/742477

thiemowmde added a project: WMDE-TechWish-Sprint-2021-12-08.Dec 8 2021, 11:21 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2021-12-08 board.
gerritbot added a comment.Dec 8 2021, 12:21 PM

Change 742712 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Support versioned static mapframes

https://gerrit.wikimedia.org/r/742712

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.13; 2021-12-13); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 8 2021, 1:00 PM
awight claimed this task.Dec 9 2021, 10:57 AM
awight renamed this task from Merge "safe" revid changes to production to Merge revid branches to production.Dec 9 2021, 10:59 AM
awight updated the task description. (Show Details)
awight updated the task description. (Show Details)
gerritbot added a comment.Dec 9 2021, 11:04 AM

Change 742472 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Pass revid parameter through to mapdata

https://gerrit.wikimedia.org/r/742472

awight mentioned this in rMSKA69bd6b670692: Pass revid parameter through to mapdata.Dec 9 2021, 11:08 AM
awight closed this task as Resolved.Dec 14 2021, 12:44 PM
awight moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2021-12-08 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL