Page MenuHomePhabricator

Change "save" to "publish" in several Growth messages
Closed, ResolvedPublic

Description

Several Growth messages say "save" where "publish" is probably more appropriate. Please check these:

keycurrent textsuggested textcomments?
growthexperiments-help-panel-suggestededits-tips-vector-visualeditor-copyedit-main-publishEither find more changes to make, or go ahead and click \"$1\" to save {{GENDER:|your}} edit!Either find more changes to make, or go ahead and click \"$1\" to publish {{GENDER:|your}} edit!
growthexperiments-help-panel-suggestededits-tips-minerva-visualeditor-copyedit-main-publishEither find more changes to make, or go ahead and tap the blue arrow button to save {{GENDER:|your}} edit!Either find more changes to make, or go ahead and tap the blue arrow button to publish {{GENDER:|your}} edit!
growthexperiments-help-panel-suggestededits-tips-vector-visualeditor-links-main-publishEither add more links, or go ahead and click \"$1\" to save {{GENDER:|your}} edit!Either add more links, or go ahead and click \"$1\" to publish {{GENDER:|your}} edit!
growthexperiments-help-panel-suggestededits-tips-minerva-visualeditor-links-main-publishEither add more links, or go ahead and tap the blue arrow button to save {{GENDER:|your}} edit!Either add more links, or go ahead and tap the blue arrow button to publish {{GENDER:|your}} edit!
growthexperiments-help-panel-suggestededits-tips-vector-visualeditor-references-main-publishEither add more references, or go ahead and click \"$1\" to save {{GENDER:|your}} edit!Either add more references, or go ahead and click \"$1\" to publish {{GENDER:|your}} edit!
growthexperiments-help-panel-suggestededits-tips-minerva-visualeditor-references-main-publishEither add more references, or go ahead and tap the blue arrow button to save {{GENDER:|your}} edit!Either add more references, or go ahead and tap the blue arrow button to publish {{GENDER:|your}} edit!
growthexperiments-help-panel-suggestededits-tips-vector-visualeditor-update-main-publishEither continue updating the article, or go ahead and click \"$1\" to save {{GENDER:|your}} edit!Either continue updating the article, or go ahead and click \"$1\" to publish {{GENDER:|your}} edit!
growthexperiments-help-panel-suggestededits-tips-minerva-visualeditor-update-main-publishEither continue updating the article, or go ahead and tap the blue arrow button to save {{GENDER:|your}} edit!Either continue updating the article, or go ahead and tap the blue arrow button to publish {{GENDER:|your}} edit!
growthexperiments-help-panel-suggestededits-tips-vector-visualeditor-expand-main-publishWhen {{GENDER:|you}} are finished expanding the article, go ahead and click \"$1\" to save {{GENDER:|your}} edit!When {{GENDER:|you}} are finished expanding the article, go ahead and click \"$1\" to publish {{GENDER:|your}} edit!
growthexperiments-help-panel-suggestededits-tips-minerva-visualeditor-expand-main-publishWhen {{GENDER:|you}} are finished expanding the article, go ahead and tap the blue arrow button to save {{GENDER:|your}} edit!When {{GENDER:|you}} are finished expanding the article, go ahead and tap the blue arrow button to publish {{GENDER:|your}} edit!
growthexperiments-addlink-summary-copyrightwarningBy saving changes, {{GENDER:|you}} agree to the [https://foundation.wikimedia.org/wiki/Terms_of_Use Terms of Use] and agree to release your contribution under the [https://creativecommons.org/licenses/by-sa/3.0/ CC BY-SA 3.0] and [https://www.gnu.org/licenses/fdl-1.3.html GFDL] licenses.By publishing changes, {{GENDER:|you}} agree to the [https://foundation.wikimedia.org/wiki/Terms_of_Use Terms of Use] and agree to release your contribution under the [https://creativecommons.org/licenses/by-sa/3.0/ CC BY-SA 3.0] and [https://www.gnu.org/licenses/fdl-1.3.html GFDL] licenses.
growthexperiments-addlink-suggestions-outdatedAnother user edited this article while {{GENDER:|you}} were reviewing it, and {{GENDER:|your}} changes could not be saved.Another user edited this article while {{GENDER:|you}} were reviewing it, and {{GENDER:|your}} changes could not be published.
growthexperiments-structuredtask-user-errorWe could not save {{GENDER:|your}} edit because {{GENDER:|you}} are no longer logged in. Please log in and try again.We could not publish {{GENDER:|your}} edit because {{GENDER:|you}} are no longer logged in. Please log in and try again.

Event Timeline

Change 732116 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/GrowthExperiments@master] Change \"save\" to \"publish\" in several messages

https://gerrit.wikimedia.org/r/732116

FYI @MMiller_WMF @RHo in case you have any comments about the updated copy

@MMiller_WMF and maybe @Tgr may have more context but IIRC this was set to "save" to accommodate wikis where there are flagged revisions?

I don't recall if that was the exact reason, but it depends on various MediaWiki settings whether the interface uses "save" or "publish" and IMO we don't want to duplicate these messages just because of that, the translator burden is already quite high. The user will see the "publish" hint in the save dialog if they need to, anyway.

The translator burden is really not a big deal. Repeating similar messages is OK. That's what translation memory is for. I remember that around 2016 it was quite important for the Editing team and also for the Legal people to write "Publish" consistently everywhere.

kostajh moved this task from Inbox to Needs Discussion on the Growth-Team board.
kostajh subscribed.

@MMiller_WMF @RHo please let us know if the proposed changes are OK.

@MMiller_WMF @RHo please let us know if the proposed changes are OK.

I am fine with the wording changes, but would like to confirm whether this will be translated appropriately on wikis with Flagged Revisions like arwiki so that it is not using inconsistent terminology that conveys "publish" in case there is a different term that more accurately means the 'published pending review'?
Currently I see arwiki uses نشر التغييرات (Google translated as "Post changes") for the action button in VE but the copyright disclaimer refers to clicking the «حفظ الصفحة» (Google translated as "save page") button which is not the same button label.

image.png (382×1 px, 73 KB)

Making the button text adapt to FlaggedRevs state never really worked so we aren't making it any worse. The relevant task is T179326: FlaggedRev's over-ride of the submit button's label via the EditPageBeforeEditButtons PHP hook doesn't work for any other code (mobile apps, mobile Web, VisualEditor, 2017 Wikitext Editor, …) I think.

FWIW the FlaggedRevs interface (in the old wikitext editor, which is the one context where it actually works) doesn't say "save" (which would bee misleading - the edit does get published in a way; anonymous readers won't see it in the default view of the article, but it's accessible to them, and it does show up in the article history, attributed to the author), it says "Submit changes".

hi @Dyolf77_WMF - seems like from discussion on this task that changing the wording from "save" to "publish" in the several strings on Growth suggested edits messages is fine. However, I wanted to ask for your input since we originally used "save" due to an assumption that "publish" might be misleading when translated on arwiki (and other wikis with FlaggedRevs) – would changing to "publish" be fine?

Hi @RHo

hi @Dyolf77_WMF - seems like from discussion on this task that changing the wording from "save" to "publish" in the several strings on Growth suggested edits messages is fine. However, I wanted to ask for your input since we originally used "save" due to an assumption that "publish" might be misleading when translated on arwiki (and other wikis with FlaggedRevs) – would changing to "publish" be fine?

Effectively, the word publish is used as the action button in VE (another translation of post), so changing save to publish on arwiki will be fine.

Tgr assigned this task to Amire80.

Change 732116 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Change \"save\" to \"publish\" in several messages

https://gerrit.wikimedia.org/r/732116