Page MenuHomePhabricator
Create Task
Maniphest T293860

PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Deprecated usage of ParserOutput::getProperty and ParserOutput::setProperty in extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(94)

ParserOutput::setProperty

normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(94)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(375): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(351): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(230): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.5/includes/GlobalFunctions.php(1005): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/ParserOutput.php(1171): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(94): ParserOutput->setProperty(string, string)
#7 /srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(26): Wikibase\Client\Hooks\ShortDescHandler->doHandle(Parser, string, string)
#8 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(3398): Wikibase\Client\Hooks\ShortDescHandler::handle(Parser, string)
#9 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(3081): Parser->callParserFunction(PPFrame_Hash, string, array)
#10 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/PPFrame_Hash.php(276): Parser->braceSubstitution(array, PPFrame_Hash)
#11 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(2917): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#12 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(936): Parser->replaceVariables(string, PPFrame_Hash)
#13 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiExpandTemplates.php(145): Parser->preprocess(string, Title, ParserOptions, NULL, PPFrame_Hash)
#14 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiMain.php(1878): ApiExpandTemplates->execute()
#15 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiMain.php(857): ApiMain->executeAction()
#16 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiMain.php(828): ApiMain->executeActionWithErrorHandling()
#17 /srv/mediawiki/php-1.38.0-wmf.5/api.php(90): ApiMain->execute()
#18 /srv/mediawiki/php-1.38.0-wmf.5/api.php(45): wfApiMain()
#19 /srv/mediawiki/w/api.php(3): require(string)
#20 {main}

ParserOutput::getProperty

normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of ParserOutput::getProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(88)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(375): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(351): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(230): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.5/includes/GlobalFunctions.php(1005): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/ParserOutput.php(1185): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(88): ParserOutput->getProperty(string)
#7 /srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(26): Wikibase\Client\Hooks\ShortDescHandler->doHandle(Parser, string, string)
#8 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(3398): Wikibase\Client\Hooks\ShortDescHandler::handle(Parser, string)
#9 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(3081): Parser->callParserFunction(PPFrame_Hash, string, array)
#10 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/PPFrame_Hash.php(276): Parser->braceSubstitution(array, PPFrame_Hash)
#11 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(2917): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#12 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(936): Parser->replaceVariables(string, PPFrame_Hash)
#13 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiExpandTemplates.php(145): Parser->preprocess(string, Title, ParserOptions, NULL, PPFrame_Hash)
#14 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiMain.php(1878): ApiExpandTemplates->execute()
#15 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiMain.php(857): ApiMain->executeAction()
#16 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiMain.php(828): ApiMain->executeActionWithErrorHandling()
#17 /srv/mediawiki/php-1.38.0-wmf.5/api.php(90): ApiMain->execute()
#18 /srv/mediawiki/php-1.38.0-wmf.5/api.php(45): wfApiMain()
#19 /srv/mediawiki/w/api.php(3): require(string)
#20 {main}
Impact
Notes

Details

Request URL
https://test.wikipedia.org/w/api.php
SubjectRepoBranchLines +/-
Rename ParserOutput and OutputPage variables to disambiguatemediawiki/extensions/Wikibasemaster+35 -35
Update deprecated calls in ShortDescHandlermediawiki/extensions/Wikibasemaster+8 -7
Update deprecated calls in ShortDescHandlermediawiki/extensions/Wikibasewmf/1.38.0-wmf.5+8 -7
Rename usages of deprecated ParserOutput::{get,set}Property() (take 2)mediawiki/extensions/Wikibasemaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Oct 20 2021, 8:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2021, 8:03 AM
Maintenance_bot added a project: Wikidata.Oct 20 2021, 8:45 AM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptOct 20 2021, 8:45 AM
• Michael subscribed.Oct 20 2021, 9:57 AM
Lucas_Werkmeister_WMDE subscribed.Oct 20 2021, 10:08 AM

Why were getProperty() and setProperty() hard-deprecated when there are still callers in production-deployed extensions that can easily be found with codesearch?

gerritbot added a comment.Oct 20 2021, 10:11 AM

Change 732272 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Update deprecated calls in ShortDescHandler

https://gerrit.wikimedia.org/r/732272

gerritbot added a project: Patch-For-Review.Oct 20 2021, 10:11 AM
Lucas_Werkmeister_WMDE claimed this task.Oct 20 2021, 10:12 AM

Okay, maybe not “easily”, given that OutputPage has similar methods that weren’t renamed, and in the codesearch context it’s not immediately obvious if an $out variable is a ParserOutput or an OutputPage.

hashar added a comment.Oct 20 2021, 1:40 PM

That has been deprecated as part of T287216: ParserOutput should implement ContentMetadataCollector specially by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/727402 . A code search has definitely been done and the patch has a bunch of Depends-On.

There was a patch for Wikibase https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/727403 and I guess after that another change introduced ParserOutput:getProperty before the hard deprecation patch got merged in core? Though CI should have caught when attempting to merge the mediawiki/core patch. So I don't quite know :-\

hashar added a parent task: T287216: ParserOutput should implement ContentMetadataCollector.Oct 20 2021, 1:41 PM
hashar mentioned this in T287216: ParserOutput should implement ContentMetadataCollector.
hashar mentioned this in T281169: 1.38.0-wmf.5 deployment blockers.Oct 20 2021, 1:45 PM
cscott subscribed.EditedOct 20 2021, 2:52 PM
In T293860#7443715, @Lucas_Werkmeister_WMDE wrote:

Okay, maybe not “easily”, given that OutputPage has similar methods that weren’t renamed, and in the codesearch context it’s not immediately obvious if an $out variable is a ParserOutput or an OutputPage.

This. It's quite hard to tell the difference between OutputPage and ParserOutput and apparently I missed a few. My apologies!

I'll note that one motivation for the change is to more clearly distinguish page properties (which are db-backed) from the similar OutputPage properties.

Lucas_Werkmeister_WMDE added a comment.Oct 20 2021, 2:55 PM

Yeah, I didn’t realize the two classes were so confusingly similar, sorry for being a bit too harsh there. (I did a quick git grep and just assumed most of them would be other ParserOutput calls, since they were on variables like $out.)

gerritbot added a comment.Oct 20 2021, 3:05 PM

Change 732354 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Wikibase@master] Rename usages of deprecated ParserOutput::{get,set}Property() (take 2)

https://gerrit.wikimedia.org/r/732354

cscott added a comment.Oct 20 2021, 3:07 PM

(Also, just sayin': this would have been caught by CI if ShortDescHandler::doHandle() were covered by any tests...)

gerritbot added a comment.Oct 20 2021, 3:07 PM

Change 732355 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Wikibase@master] Rename ParserOutput and OutputPage variables to disambiguate

https://gerrit.wikimedia.org/r/732355

Lucas_Werkmeister_WMDE added a comment.Oct 20 2021, 3:09 PM

It is covered by tests, the tests just happen to mock the parser output instead of using the real implementation.

gerritbot added a comment.Oct 20 2021, 3:11 PM

Change 732354 abandoned by C. Scott Ananian:

[mediawiki/extensions/Wikibase@master] Rename usages of deprecated ParserOutput::{get,set}Property() (take 2)

Reason:

Abandon in favor of I70706415ae657f6783b7ae78e2dbe1b96ca31dbe

https://gerrit.wikimedia.org/r/732354

gerritbot added a comment.Oct 20 2021, 3:21 PM

Change 732332 had a related patch set uploaded (by C. Scott Ananian; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@wmf/1.38.0-wmf.5] Update deprecated calls in ShortDescHandler

https://gerrit.wikimedia.org/r/732332

gerritbot added a comment.Oct 20 2021, 4:56 PM

Change 732332 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.38.0-wmf.5] Update deprecated calls in ShortDescHandler

https://gerrit.wikimedia.org/r/732332

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 20 2021, 5:00 PM
Stashbot added a comment.Oct 20 2021, 5:00 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-20T17:00:47Z] <hashar@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/Wikibase/client: Update deprecated calls to ParserOutput in ShortDescHandler - T293860 (duration: 01m 03s)

hashar closed this task as Resolved.Oct 20 2021, 5:01 PM

There was just a few of those happening in production (once per hour or so). I have deployed the change to production. Thank you for the quick fix!

gerritbot added a comment.Oct 20 2021, 5:21 PM

Change 732272 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update deprecated calls in ShortDescHandler

https://gerrit.wikimedia.org/r/732272

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.6; 2021-10-26); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 20 2021, 6:00 PM
Krinkle moved this task from Untriaged to Oct 2021 on the Wikimedia-production-error board.Oct 25 2021, 6:42 PM
gerritbot added a comment.Nov 24 2021, 12:50 PM

Change 732355 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Rename ParserOutput and OutputPage variables to disambiguate

https://gerrit.wikimedia.org/r/732355

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Nov 24 2021, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits