Live preview fails when section=new&nosummary=1
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Nardog
	Oct 20 2021, 1:18 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Enable "Show previews without reloading the page" in Preferences
Open https://test.wikipedia.org/w/index.php?title=Wikipedia_talk:Sandbox&action=edit&section=new&nosummary=1
Enter something in the textbox
Click "Show preview" ~~or "Show changes"~~

What happens?:
The browser navigates to action=submit, same as live preview turned off.

What should have happened instead?:
Live preview happens.

mediawiki.action.edit.preview.js$191:

summary = OO.ui.infuse( $( '#wpSummaryWidget' ) );

This fails because there is no #wpSummaryWidget.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make live preview work when section=new&nosummary=1	mediawiki/core	master	+7 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T41272 Bugs in "Live preview" feature (tracking)
		Resolved	BUG REPORT	Nardog	T293892 Live preview fails when section=new&nosummary=1

Event Timeline

Nardog created this task.Oct 20 2021, 1:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2021, 1:18 PM

I didn't even know it existed... but it does.
https://www.mediawiki.org/wiki/Manual:Parameters_to_index.php#Edit_and_submit

Why do we even use OO.ui.infuse for the summary widget (when we don't for the buttons)? Would there be any problem with simply using $( '#wpSummary' ).val()?

In T293892#7444510, @Nardog wrote:

Why do we even use OO.ui.infuse for the summary widget (when we don't for the buttons)?

This is for the character limit functionality (visibleCodePointLimit).

Would there be any problem with simply using $( '#wpSummary' ).val()?

That functionality would break.

In T293892#7444510, @Nardog wrote:

Why do we even use OO.ui.infuse for the summary widget (when we don't for the buttons)? Would there be any problem with simply using $( '#wpSummary' ).val()?

To elaborate: .val() for reading the value would probably be fine, but .val( foo ) for setting the value would probably cause problems (some parts of the interface would see the new value and some would not, e.g. maybe the character limit as @Jdforrester-WMF says), so to avoid easy mistakes, we always use OO.ui.infuse when working with OOUI widgets.

(when we don't for the buttons)

I think that's a little bit of historical weirdness… this code was once upon a time loaded by LiquidThreads, which had non-OOUI buttons, so it was kept this way to keep it working. I'm not sure if that's still needed, maybe it can be changed.

Nardog updated the task description. (Show Details)Oct 20 2021, 7:46 PM

Change 732421 had a related patch set uploaded (by Nardog; author: Nardog):

[mediawiki/core@master] Make live preview work when section=new&nosummary=1

https://gerrit.wikimedia.org/r/732421

gerritbot added a project: Patch-For-Review.Oct 20 2021, 7:54 PM

Change 732421 merged by jenkins-bot:

[mediawiki/core@master] Make live preview work when section=new&nosummary=1

https://gerrit.wikimedia.org/r/732421

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 21 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2021, 5:10 PM