Timeline.php on line 157
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	hashar
	Oct 21 2021, 1:39 PM

Description

Error

mwversion: ``
reqId: 0649b54c-7dbc-46c5-a605-c31c7ebaa3ea

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 2 passed to Shellbox\Command\BoxedCommand::inputFileFromString() must be of the type string, null given, called in /srv/mediawiki/php-1.38.0-wmf.4/extensions/timeline/includes/Timeline.php on line 157

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.4/vendor/wikimedia/shellbox/src/Command/BoxedCommand.php(52)
#0 /srv/mediawiki/php-1.38.0-wmf.4/extensions/timeline/includes/Timeline.php(157): Shellbox\Command\BoxedCommand->inputFileFromString(string, NULL)
#1 /srv/mediawiki/php-1.38.0-wmf.4/extensions/timeline/includes/Timeline.php(78): Timeline::renderTimeline(NULL, array)
#2 /srv/mediawiki/php-1.38.0-wmf.4/includes/parser/Parser.php(3953): Timeline::onTagHook(NULL, array, Parser, PPFrame_Hash)
#3 /srv/mediawiki/php-1.38.0-wmf.4/includes/parser/CoreParserFunctions.php(1163): Parser->extensionSubstitution(array, PPFrame_Hash)
#4 /srv/mediawiki/php-1.38.0-wmf.4/includes/parser/Parser.php(3387): CoreParserFunctions::tagObj(Parser, PPFrame_Hash, array)
#5 /srv/mediawiki/php-1.38.0-wmf.4/includes/parser/Parser.php(3072): Parser->callParserFunction(PPFrame_Hash, string, array)
#6 /srv/mediawiki/php-1.38.0-wmf.4/includes/parser/PPFrame_Hash.php(273): Parser->braceSubstitution(array, PPFrame_Hash)
#7 /srv/mediawiki/php-1.38.0-wmf.4/includes/parser/Parser.php(2910): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#8 /srv/mediawiki/php-1.38.0-wmf.4/includes/parser/Parser.php(1578): Parser->replaceVariables(string)
#9 /srv/mediawiki/php-1.38.0-wmf.4/includes/parser/Parser.php(653): Parser->internalParse(string)
#10 /srv/mediawiki/php-1.38.0-wmf.4/includes/content/WikitextContentHandler.php(293): Parser->parse(string, Title, ParserOptions, boolean, boolean, NULL)
#11 /srv/mediawiki/php-1.38.0-wmf.4/includes/content/ContentHandler.php(1665): WikitextContentHandler->fillParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, ParserOutput)
#12 /srv/mediawiki/php-1.38.0-wmf.4/includes/content/AbstractContent.php(573): ContentHandler->getParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#13 /srv/mediawiki/php-1.38.0-wmf.4/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, NULL, ParserOptions, boolean)
#14 /srv/mediawiki/php-1.38.0-wmf.4/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#15 /srv/mediawiki/php-1.38.0-wmf.4/includes/Revision/RevisionRenderer.php(217): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#16 /srv/mediawiki/php-1.38.0-wmf.4/includes/Revision/RevisionRenderer.php(154): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#17 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#18 /srv/mediawiki/php-1.38.0-wmf.4/includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#19 /srv/mediawiki/php-1.38.0-wmf.4/includes/Storage/DerivedPageDataUpdater.php(1389): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#20 [internal function]: MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#21 /srv/mediawiki/php-1.38.0-wmf.4/includes/edit/PreparedEdit.php(104): call_user_func(array)
#22 /srv/mediawiki/php-1.38.0-wmf.4/includes/edit/PreparedEdit.php(119): MediaWiki\Edit\PreparedEdit->getOutput()
#23 /srv/mediawiki/php-1.38.0-wmf.4/includes/Storage/DerivedPageDataUpdater.php(1359): MediaWiki\Edit\PreparedEdit->__get(string)
#24 /srv/mediawiki/php-1.38.0-wmf.4/includes/page/WikiPage.php(2058): MediaWiki\Storage\DerivedPageDataUpdater->getPreparedEdit()
#25 /srv/mediawiki/php-1.38.0-wmf.4/extensions/ConfirmEdit/SimpleCaptcha/SimpleCaptcha.php(616): WikiPage->prepareContentForEdit(WikitextContent, NULL, User)
#26 /srv/mediawiki/php-1.38.0-wmf.4/extensions/ConfirmEdit/SimpleCaptcha/SimpleCaptcha.php(835): SimpleCaptcha->shouldCheck(WikiPage, WikitextContent, string, DerivativeContext)
#27 /srv/mediawiki/php-1.38.0-wmf.4/extensions/ConfirmEdit/SimpleCaptcha/SimpleCaptcha.php(871): SimpleCaptcha->doConfirmEdit(WikiPage, WikitextContent, string, DerivativeContext, User)
#28 /srv/mediawiki/php-1.38.0-wmf.4/extensions/ConfirmEdit/includes/ConfirmEditHooks.php(51): SimpleCaptcha->confirmEditMerged(DerivativeContext, WikitextContent, Status, string, User, boolean)
#29 /srv/mediawiki/php-1.38.0-wmf.4/includes/HookContainer/HookContainer.php(338): ConfirmEditHooks::confirmEditMerged(DerivativeContext, WikitextContent, Status, string, User, boolean)
#30 /srv/mediawiki/php-1.38.0-wmf.4/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#31 /srv/mediawiki/php-1.38.0-wmf.4/includes/HookContainer/HookRunner.php(1467): MediaWiki\HookContainer\HookContainer->run(string, array)
#32 /srv/mediawiki/php-1.38.0-wmf.4/includes/editpage/Constraint/EditFilterMergedContentHookConstraint.php(90): MediaWiki\HookContainer\HookRunner->onEditFilterMergedContent(DerivativeContext, WikitextContent, Status, string, User, boolean)
#33 /srv/mediawiki/php-1.38.0-wmf.4/includes/editpage/Constraint/EditConstraintRunner.php(88): MediaWiki\EditPage\Constraint\EditFilterMergedContentHookConstraint->checkConstraint()
#34 /srv/mediawiki/php-1.38.0-wmf.4/includes/EditPage.php(2281): MediaWiki\EditPage\Constraint\EditConstraintRunner->checkConstraints()
#35 /srv/mediawiki/php-1.38.0-wmf.4/includes/EditPage.php(1686): EditPage->internalAttemptSave(NULL, boolean, boolean)
#36 /srv/mediawiki/php-1.38.0-wmf.4/includes/api/ApiEditPage.php(507): EditPage->attemptSave(NULL)
#37 /srv/mediawiki/php-1.38.0-wmf.4/includes/api/ApiMain.php(1878): ApiEditPage->execute()
#38 /srv/mediawiki/php-1.38.0-wmf.4/includes/api/ApiMain.php(826): ApiMain->executeAction()
#39 /srv/mediawiki/php-1.38.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(111): ApiMain->execute()
#40 /srv/mediawiki/php-1.38.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(422): ApiVisualEditorEdit->saveWikitext(Title, string, array)
#41 /srv/mediawiki/php-1.38.0-wmf.4/includes/api/ApiMain.php(1878): ApiVisualEditorEdit->execute()
#42 /srv/mediawiki/php-1.38.0-wmf.4/includes/api/ApiMain.php(857): ApiMain->executeAction()
#43 /srv/mediawiki/php-1.38.0-wmf.4/includes/api/ApiMain.php(828): ApiMain->executeActionWithErrorHandling()
#44 /srv/mediawiki/php-1.38.0-wmf.4/api.php(90): ApiMain->execute()
#45 /srv/mediawiki/php-1.38.0-wmf.4/api.php(45): wfApiMain()
#46 /srv/mediawiki/w/api.php(3): require(string)
#47 {main}

Impact

I guess one can not add any modification to https://nl.wikipedia.org/wiki/IPhone due to an issue with an EasyTimeline definition?

Notes

Details

Request URL: https://nl.wikipedia.org/wiki/IPhone?veaction=edit&section=4

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Input may be null when rendering a self-closing tag `<timeline />`	mediawiki/extensions/timeline	wmf/1.38.0-wmf.5	+6 -3
	Input may be null when rendering a self-closing tag `<timeline />`	mediawiki/extensions/timeline	master	+6 -3

Customize query in gerrit

Related Objects

Mentioned In: T281169: 1.38.0-wmf.5 deployment blockers

Event Timeline

hashar created this task.Oct 21 2021, 1:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2021, 1:39 PM

It happened on wmf.4 as well, there are a few examples when searching in Kibana for "timeline" and there were a few triggered from https://en.wikipedia.org/wiki/Module:Sandbox/Zyxw/test

Argument 2 passed to Shellbox\Command\BoxedCommand::inputFileFromString() must be of the type string, null given, called in /srv/mediawiki/php-1.38.0-wmf.4/extensions/timeline/includes/Timeline.php on line 157

From Parsoid en.wikipedia.org/w/rest.php/en.wikipedia.org/v3/page/pagebundle/Module%3ASandbox%2FZyxw%2Ftest/979645383

I am assuming it is related to some bad input in the source rather than a general issue.

hashar mentioned this in T281169: 1.38.0-wmf.5 deployment blockers.Oct 21 2021, 1:50 PM

Change 734366 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/timeline@master] Input may be null when rendering a self-closing tag `<timeline />`

https://gerrit.wikimedia.org/r/734366

gerritbot added a project: Patch-For-Review.Oct 25 2021, 6:01 PM

matmarex claimed this task.Oct 25 2021, 6:01 PM

Change 734366 merged by jenkins-bot:

[mediawiki/extensions/timeline@master] Input may be null when rendering a self-closing tag `<timeline />`

https://gerrit.wikimedia.org/r/734366

Change 734312 had a related patch set uploaded (by Legoktm; author: Bartosz Dziewoński):

[mediawiki/extensions/timeline@wmf/1.38.0-wmf.5] Input may be null when rendering a self-closing tag `<timeline />`

https://gerrit.wikimedia.org/r/734312

Change 734312 merged by jenkins-bot:

[mediawiki/extensions/timeline@wmf/1.38.0-wmf.5] Input may be null when rendering a self-closing tag `<timeline />`

https://gerrit.wikimedia.org/r/734312

Mentioned in SAL (#wikimedia-operations) [2021-10-25T18:40:33Z] <jforrester@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/timeline/includes/Timeline.php: Backport: [[gerrit:734312|Input may be null when rendering a self-closing tag <timeline /> (T294020)]] (duration: 00m 55s)