Page MenuHomePhabricator
Create Task
Maniphest T294059

Declines due to API settings
Closed, ResolvedPublic
Actions

Description

Greetings FRTech,

I detected a new sort of decline in our decline mix recently and made an inquiry with Ingenico about them. The decline is 'scenario not successful' (see below) which is new to me. After pushing Ingenico about this, they suggest that there is an issue with our recurring API call.

From Ingenico: Wiki is sending isRecurring=1 instead of isRecurring=true. Also I'm confused why it is being sent in cardPaymentMethodSpecificInput instead of hostedCheckoutSpecificInput. It seems like if they want to use recurring so they also need to submit endDate and minFrequency to be able to perform 3Dv2. Maybe it would be good to have some technical person from Wiki to contact me to go over their API calls.

Can someone from FRTech be available to have this call with myself and Ingenico to explore this topic and hopefully favorably impact these declines?

image.png (728×351 px, 48 KB)

Details

SubjectRepoBranchLines +/-
Set isRecurring value to boolean instead of numbersmediawiki/extensions/DonationInterfacemaster+15 -0
Customize query in gerrit

Event Timeline

EMartin created this task.Oct 21 2021, 8:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2021, 8:06 PM
Ejegg subscribed.Oct 21 2021, 10:13 PM

Wiki is sending isRecurring=1 instead of isRecurring=true. Also I'm confused why it is being sent in cardPaymentMethodSpecificInput instead of hostedCheckoutSpecificInput. It seems like if they want to use recurring so they also need to submit endDate and minFrequency to be able to perform 3Dv2. Maybe it would be good to have some technical person from Wiki to contact me to go over their API calls.

We'd be happy to get some input from them! In the meantime, we could clarify whether they're talking about the initial setup (where we use a hosted checkout and where we DO put the isRecurring flag under the hostedCheckoutSpecificInput) or a subsequent installment (where we use the base create payment API call that has no hostedCheckoutSpecificInput) . We can certainly switch isRecurring to use true and false instead of 1 and 0 if their platform now requires it.

EMartin added a comment.Oct 22 2021, 5:59 PM

//From Ingenico: The logs I received from my team were not very clear so I couldn’t distinguish if you are submitting the “hosted checkout” API or the “create payment” API.

So based on your teams comments it looks like the subsequent installment (create payment API) is correct, indeed the only change required for this is to change isRecurring 1 and 0 to true and false and everything else is OK.

For the initial setup (hosted checkout API) I have not received any logs from my team, so hopefully your team can provide an example of this call. This is the API call that requires the 3D fields so we should focus our efforts on getting this API call right.//

gerritbot added a comment.Oct 25 2021, 5:28 PM

Change 734358 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] Set isRecurring value to boolean instead of numbers

https://gerrit.wikimedia.org/r/734358

gerritbot added a project: Patch-For-Review.Oct 25 2021, 5:28 PM
Damilare claimed this task.Oct 25 2021, 5:30 PM
EMartin added a comment.Oct 25 2021, 6:40 PM

Please let me know if you would like to have a call with Ingenico to discuss the API 3D fields correct.

XenoRyet moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Oct 25 2021, 7:51 PM
XenoRyet added a project: Fundraising Sprint Technical debt house of horrors.
XenoRyet added a project: fundraising sprint Universal Cereal Bus.Oct 26 2021, 8:10 PM
Ejegg moved this task from Backlog to Doing on the fundraising sprint Universal Cereal Bus board.Oct 27 2021, 3:27 PM
Damilare moved this task from Doing to Review on the fundraising sprint Universal Cereal Bus board.Oct 28 2021, 3:21 PM
gerritbot added a comment.Oct 28 2021, 4:34 PM

Change 734358 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Set isRecurring value to boolean instead of numbers

https://gerrit.wikimedia.org/r/734358

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Oct 28 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 28 2021, 5:10 PM
Damilare moved this task from Review to Pending Deployment on the fundraising sprint Universal Cereal Bus board.Oct 29 2021, 1:33 PM
Ejegg moved this task from Pending Deployment to Done on the fundraising sprint Universal Cereal Bus board.Nov 2 2021, 3:00 AM

This has been deployed

EMartin added a comment.Nov 4 2021, 8:22 PM

@Ejegg, could I kindly get a copy of the API call to have Ingenico review so I can close this out with them?

XenoRyet closed this task as Resolved.Nov 9 2021, 8:12 PM
XenoRyet set Final Story Points to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL