Page MenuHomePhabricator

SecurePoll not tagging duplicate votes consistently
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • For some duplicate votes, this works as expected.
  • For some others (it is not clear what causes this), nothing is output at all even when the UA and IP is both the same (i.e. the vote is a duplicate)

What should have happened instead?:

  • All duplicate votes should be tagged as such.

Event Timeline

Ah, in T277277 it seems to suggest this isn't based on IP/UA but on cookies(?), perhaps that's the reason for the inconsistency here?

@jrbs that is what I remember from the code too: that it is Cookie based.

This is why in addition to the automated duplication removal feature of SecurePoll, all elections should be reviewed by admins/scrutineers and votes be cross-checked in terms of their IP and UA, in search of (a) socks, and (b) use of proxies.

In the past, AHT stepped in to support Trust & Safety with the time-sensitive matter of the Board Elections by providing help with SecurePoll. Unfortunately, at this time we can no longer support nor maintain SecurePoll. Per the Foundation leadership’s instructions, AHT is dedicating all of our time and energy to other critical efforts.

It sounds like what this needs is a brief indicator of what "Duplicate" actually means (matching cookies), perhaps only visible to electionadmins?

It sounds like what this needs is a brief indicator of what "Duplicate" actually means (matching cookies), perhaps only visible to electionadmins?

This is already only visible to electadmins, so I'll submit a patch changing the text from "Duplicate" to "Dup cookies", and add some internal notes on how to proceed.

Change 739812 had a related patch set uploaded (by Tks4Fish; author: Tks4Fish):

[mediawiki/extensions/SecurePoll@master] i18n: Changing 'Dup' to 'Duplicate' and 'Duplicate' to 'Dup cookies' to clarify

https://gerrit.wikimedia.org/r/739812

Change 739812 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] i18n: Changing 'Dup' to 'Duplicate' and 'Duplicate' to 'Dup cookies' to clarify

https://gerrit.wikimedia.org/r/739812