Page MenuHomePhabricator
Create Task
Maniphest T294082

Netbox/DNS, browse parents prefixes to set site
Closed, ResolvedPublic
Actions

Description

All IPs under 2a02:ec80::/32 are set to belong to esams (eg. included in the wikimedia.org-esams).
While IPs in 2a02:ec80:600::/48 should be for drmrs (eg. wikimedia.org-drmrs)

This is because 2a02:ec80::/32 used to be exclusively for esams, but part of it has now been assigned to drmrs.

However removing the site attribute of 2a02:ec80::/32, causes all the IPs under it to be "site-less".

This is because the script only takes the topmost prefix into account.

Instead it should browse the prefixes tree from the IP upward, and stop at the first site detected. Only falling back to global if there is no match at all.

Details

SubjectRepoBranchLines +/-
Use most specific prefix for dns record site assignmentoperations/software/netbox-extrasmaster+5 -2
Customize query in gerrit

Related Objects

Event Timeline

ayounsi created this task.Oct 22 2021, 8:28 AM
Restricted Application added a project: Infrastructure-Foundations. · View Herald TranscriptOct 22 2021, 8:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
taavi subscribed.Oct 22 2021, 8:31 AM
cmooney subscribed.Oct 22 2021, 8:33 AM
gerritbot added a comment.Oct 22 2021, 8:34 AM

Change 732919 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/software/netbox-extras@master] Use most specific prefix for dns record site assignment

https://gerrit.wikimedia.org/r/732919

gerritbot added a project: Patch-For-Review.Oct 22 2021, 8:34 AM
gerritbot added a comment.Oct 25 2021, 9:47 AM

Change 732919 merged by jenkins-bot:

[operations/software/netbox-extras@master] Use most specific prefix for dns record site assignment

https://gerrit.wikimedia.org/r/732919

taavi mentioned this in rOSNEa428fe7881c8: Use most specific prefix for dns record site assignment.Oct 25 2021, 9:59 AM
Volans closed this task as Resolved.Oct 25 2021, 10:05 AM
Volans claimed this task.

With the fix of the above patch merged I've run the dns.netbox cookbook that has moved over the records to the correct zonefile. I've then removed the 'site' from the 2a02:ec80::/32 container in Netbox as it's now used cross-site and re-run the cookbook in dry-run mode to confirm there are no pending changes. All looks good. Resolving.

@ayounsi feel free to re-open if you think there are additional modifications to do on the Netbox or automation side.

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2021, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL