Page MenuHomePhabricator

The tag filter on a history page should be within a <label> element
Closed, ResolvedPublic


Author: theevilipaddress

On every revision history, there's an input field which allows us to search for a specific tag. However, unlike all other forms, select menus or checkboxes, the label is not within a label element. The label element is used so that I can click on the label and have the cursor focused on the input field. This is quite useful and should be added for this field, too.

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport set Reference to bz27410.
bzimport added a subscriber: Unknown Object (MLST).

theevilipaddress wrote:

Patch using Xml::label

I added a patch that wraps the label into a <label> tag. I thought it was an AbuseFilter related addition, which is why I didn't find it, but actually it's done by the core.