Page MenuHomePhabricator

Double edit tab is inconsistently displayed in desktop Minerva
Closed, DuplicatePublicBUG REPORT

Description

List of steps to reproduce:

What happens?:

  • In the page actions menu,
    • on wide screens two distinct icons are used, of which one (source editing) is labelled, one is not;
    • on narrow screens two identical pencil icons are used, distinguishable only by their tooltips (of which one refers to VisualEditor specifically, the other only vaguely to editing the introduction).
  • For section headings, two identical pencil icons with identical tooltips are shown on top of each other.

What should have happened instead?:

  • In the page actions menu, on wide screens either both icons should be labelled or none of them; on narrow screens the distinct icons need to be used.
  • For section headings, distinct editing icons and tooltips need to be used.
  • Ideally, the icons should be consistent with those in T289723.

Screenshot from 2021-10-24 16-47-11.png (678×951 px, 124 KB)

Event Timeline

Change 739233 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update multi-tab code after changes in Minerva

https://gerrit.wikimedia.org/r/739233

Esanders renamed this task from Double edit tab is inconsistently displayed in Minerva to Double edit tab is inconsistently displayed in desktop Minerva.Nov 25 2021, 11:01 AM

Change 739233 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update multi-tab code after changes in Minerva

https://gerrit.wikimedia.org/r/739233