Page MenuHomePhabricator
Create Task
Maniphest T294296

Special:MobileLanguages is missing an i18n message on Special:SpecialPages
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The link to Special:MobileLanguages appears with a missing translation key ⧼mobilelanguages⧽.

image.png (216×751 px, 32 KB)

https://codesearch.wmcloud.org/search/?q=mobilelanguages&i=nope&files=&excludeFiles=&repos= returns no results.

What should have happened instead?:
The mobilelanguages i18n key should be defined and translatable.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Hide Special:MobileLanguages on Special:SpecialPagesmediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

AntiCompositeNumber created this task.Oct 25 2021, 7:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2021, 7:04 PM
Zabe updated the task description. (Show Details)Oct 25 2021, 7:23 PM
Jdlrobson added projects: patch-welcome, Web-Team-Backlog-Archived (Needs Prioritization (Tech)).Oct 25 2021, 7:34 PM
AntiCompositeNumber added a subscriber: Jdlrobson.Oct 25 2021, 8:41 PM

Looks like this is caused by rEMFR41f0bc6a0b33: Adds mw-mf-special-page class to Mobile special pages (cc @Jdlrobson). Previously SpecialMobileLanguages inherited from MobileSpecialPage, which hides pages from Special:SpecialPages by default. After the change it inherits from SpecialPage directly, which does not. Special:MobileLanguages appearing in Special:SpecialPages seems unintentional, given that no i18n key was defined for it.

Given that, I think it's probably best to just hide it again.

Jdlrobson added a comment.Oct 25 2021, 8:57 PM

Yeh that sounds correct. Thanks for working out what happened there @AntiCompositeNumber

gerritbot added a comment.Oct 25 2021, 8:57 PM

Change 734402 had a related patch set uploaded (by AntiCompositeNumber; author: AntiCompositeNumber):

[mediawiki/extensions/MobileFrontend@master] Hide Special:MobileLanguages on Special:SpecialPages

https://gerrit.wikimedia.org/r/734402

gerritbot added a project: Patch-For-Review.Oct 25 2021, 8:57 PM
gerritbot added a comment.Oct 26 2021, 5:24 PM

Change 734402 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Hide Special:MobileLanguages on Special:SpecialPages

https://gerrit.wikimedia.org/r/734402

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Oct 26 2021, 6:00 PM
Jdlrobson closed this task as Resolved.Oct 26 2021, 6:01 PM
Jdlrobson claimed this task.

The link is no longer on https://en.wikipedia.beta.wmflabs.org/wiki/Special:SpecialPages
Thanks for the fix!

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2021, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits