Page MenuHomePhabricator

Special:MobileLanguages is missing an i18n message on Special:SpecialPages
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The link to Special:MobileLanguages appears with a missing translation key ⧼mobilelanguages⧽.

image.png (216×751 px, 32 KB)

https://codesearch.wmcloud.org/search/?q=mobilelanguages&i=nope&files=&excludeFiles=&repos= returns no results.

What should have happened instead?:
The mobilelanguages i18n key should be defined and translatable.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

Looks like this is caused by rEMFR41f0bc6a0b33: Adds mw-mf-special-page class to Mobile special pages (cc @Jdlrobson). Previously SpecialMobileLanguages inherited from MobileSpecialPage, which hides pages from Special:SpecialPages by default. After the change it inherits from SpecialPage directly, which does not. Special:MobileLanguages appearing in Special:SpecialPages seems unintentional, given that no i18n key was defined for it.

Given that, I think it's probably best to just hide it again.

Yeh that sounds correct. Thanks for working out what happened there @AntiCompositeNumber

Change 734402 had a related patch set uploaded (by AntiCompositeNumber; author: AntiCompositeNumber):

[mediawiki/extensions/MobileFrontend@master] Hide Special:MobileLanguages on Special:SpecialPages

https://gerrit.wikimedia.org/r/734402

Change 734402 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Hide Special:MobileLanguages on Special:SpecialPages

https://gerrit.wikimedia.org/r/734402